From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B41C2BCA1 for ; Fri, 7 Jun 2019 18:05:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35A4F208C0 for ; Fri, 7 Jun 2019 18:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559930733; bh=QDirH5m/oJkRKK89K6LtLYmgK7DwxkhF3NI+YBA+ey0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=cyj5gQ74jHmbiKqqRJwiDR0BU0E5bmKIGw8oGY58FsGyniSkV0QwVfdtFyFJ3yqmp DLtgqVCkp4XVmAVxqJ8BObDnBLCFyu6t3CULM+S2ADRnTA7dUxFLigU8Byd0bUCx8U l5r8yF4VkgDcfNf8CSMIu9ewuaxJZ4grw5ugRXEM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729921AbfFGSFc (ORCPT ); Fri, 7 Jun 2019 14:05:32 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:34737 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729817AbfFGSFc (ORCPT ); Fri, 7 Jun 2019 14:05:32 -0400 Received: by mail-lf1-f65.google.com with SMTP id y198so2308450lfa.1 for ; Fri, 07 Jun 2019 11:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4AvJFyeYPhoZ4OqCr1dphehPV0ub1oVxmCWbJKgWsTI=; b=d315/RM0DaMH44my3nNzmVmEhTs+nmHZuuQf+pKqz9YU+VjDMhvTt+Yvh514Ss3VZ3 osVtbUYyVCFBmdkSg2kW5jq84b2tec/7sH0g88lborkaDjwnEQCiquJ2Gjh042t4qJRK O0Z2hoSc9g3XgDPMu2hQ/afW7OGSyKvzIuScc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4AvJFyeYPhoZ4OqCr1dphehPV0ub1oVxmCWbJKgWsTI=; b=lvR8m4HxTpUzkOFFDZFjzf+iI/toYUB/vhtAj8iypW+YInxuyyZiI9rMYwC89piQ9b +eVL2hJPmD4gYCs9qS/VzNugJqe5rSkMKhLwOiv1YS96olumI5PwABdgTGwQ6ljLiENy F+VTWplefzv/y6LasGXM5POZm6A0aVMLqWYJOBuCM3aE84VXGQAgAjbCEhJOad98Ue32 aii0pJ1H3o6SKZ7hQ0PEVqrR5PAQLPWvEbfbrMCjrC3us0FXE5fo6oPbIwUHqNzJeAex MKS3Yxabf5RG4PS4CP8eYIMJ++OYhHbmZOHizzXRN2YhBGzW7TCwfif3sCGiArhPXHBF lk5w== X-Gm-Message-State: APjAAAWHJi4hj03ESgVu2/7ByFx6r4Aoo1JmLvYUtZToQJwjuhyTHRp1 Vikk07PcdHb6rgA+7UqKXSqr2YwItdY= X-Google-Smtp-Source: APXvYqzKclvMNDZkxGxiO71ZoXnxfnTFJcij3VcjQY0zs+3CX7noxn0APRRTLgJLw5pvyOnroUY/rQ== X-Received: by 2002:ac2:52ac:: with SMTP id r12mr5038136lfm.126.1559930730145; Fri, 07 Jun 2019 11:05:30 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id d65sm608242lfd.72.2019.06.07.11.05.29 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jun 2019 11:05:29 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id j29so2281631lfk.10 for ; Fri, 07 Jun 2019 11:05:29 -0700 (PDT) X-Received: by 2002:a19:2d41:: with SMTP id t1mr27328138lft.79.1559930729175; Fri, 07 Jun 2019 11:05:29 -0700 (PDT) MIME-Version: 1.0 References: <20190522032144.10995-1-deepa.kernel@gmail.com> <20190529161157.GA27659@redhat.com> <20190604134117.GA29963@redhat.com> <20190606140814.GA13440@redhat.com> <20190606140852.GB13440@redhat.com> In-Reply-To: <20190606140852.GB13440@redhat.com> From: Linus Torvalds Date: Fri, 7 Jun 2019 11:05:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] select: change do_poll() to return -ERESTARTNOHAND rather than -EINTR To: Oleg Nesterov Cc: Andrew Morton , Deepa Dinamani , Linux List Kernel Mailing , Arnd Bergmann , Davidlohr Bueso , Jens Axboe , Davidlohr Bueso , Eric Wong , Jason Baron , linux-fsdevel , linux-aio@kvack.org, omar.kilani@gmail.com, Thomas Gleixner , stable , Al Viro , "Eric W. Biederman" , David Laight Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jun 6, 2019 at 7:09 AM Oleg Nesterov wrote: > > do_poll() returns -EINTR if interrupted and after that all its callers > have to translate it into -ERESTARTNOHAND. Change do_poll() to return > -ERESTARTNOHAND and update (simplify) the callers. Ack. The *right* return value will actually be then chosen by poll_select_copy_remaining(), which will turn ERESTARTNOHAND to EINTR when it can't update the timeout. Except for the cases that use restart_block and do that instead and don't have the whole timeout restart issue as a result. Linus