From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BFD8C43331 for ; Sun, 10 Nov 2019 21:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FD852080F for ; Sun, 10 Nov 2019 21:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573420265; bh=iWZwTfYgxn8ONPQ9TtbJkN/r5joAryjZhtfnsnBXHS0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=pRBtDyUPCdWqskMAUqS/ouAbqlAnlsz/HtFHnjd4Bod+saW37VYDDLmGkvD9SaK33 hSMYuzkK1wIdJHR9hIqX/RrTBF1GkMb+6a98fRdYYjE15KE2Ctr58y3STdoDOK823L BB6MaqO+c/pFq6ztiyqJYAXhlf+pEjBxPN4EuIzE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727128AbfKJVLC (ORCPT ); Sun, 10 Nov 2019 16:11:02 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:42105 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727109AbfKJVLB (ORCPT ); Sun, 10 Nov 2019 16:11:01 -0500 Received: by mail-lj1-f194.google.com with SMTP id n5so11575537ljc.9 for ; Sun, 10 Nov 2019 13:11:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sw0pGWOp+H0Cc/o3nartd+rrdu30v5KC8Ks0EukSTW0=; b=RAfCRzWXqkBygzjvTQF7B/q3F9bZcWhNFKa+vgcKxcPhwpgR7QOlK6Eii8RWszMJSj /GKxKFp6PJbUk5mDWk1Rs08zEWAX5Km6Ng5cuqqTumC+Wxu94ZiBemBAFzFqqkBvwDF2 D0F/g+SzyQvat+TyfcmfcY6DipCQs83wis1FY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sw0pGWOp+H0Cc/o3nartd+rrdu30v5KC8Ks0EukSTW0=; b=gEia3GM4r4v5SnLD1LR4dzTdQa63VY/EekdNtmSSu3cW1wTlxLrLer8eW/FeWHe8zB RKXae9HGuYAPxiJypcprVeUKQVyA9AbEOyLPFi1yny/ZulSoV3pP7VBeRlnhEHrVhLIw VIQxltirKY4NBPiQUL4EZ0WOX6H2tzSnHiUsKBA17y4Q+9J2JHTS7welViNcMzQNctXH tT/Vwi+Wp+R6qxVcPpM4O4nhMXiQZOP1I4CjWStmRPC8pODfLjrszUCkU8IR228wskAr hxv2ikKGHilXhOtlfv8aPIZB0yoSY7Fjibo+nSqRj9GhJrHKVETPYG4al5g2um7hJfis n5gw== X-Gm-Message-State: APjAAAViVKmx0yQdQ2hGzHiO43FB6CxqcX8qgROqFcEG4BTqrmpiZjIq dtmhTFuhAGAdD8eJHXXAEuq4dUWIkZE= X-Google-Smtp-Source: APXvYqx8Tl6qPZNLN9gtGuyycchXo1GLNqIM+eJltlItlP32L2j0F1aTjgK1DWu+5+yWmUtUUzlYag== X-Received: by 2002:a2e:984f:: with SMTP id e15mr13769240ljj.109.1573420259295; Sun, 10 Nov 2019 13:10:59 -0800 (PST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com. [209.85.208.177]) by smtp.gmail.com with ESMTPSA id 190sm7674421ljj.72.2019.11.10.13.10.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Nov 2019 13:10:56 -0800 (PST) Received: by mail-lj1-f177.google.com with SMTP id k15so11597158lja.3 for ; Sun, 10 Nov 2019 13:10:56 -0800 (PST) X-Received: by 2002:a2e:8809:: with SMTP id x9mr13861151ljh.82.1573420256107; Sun, 10 Nov 2019 13:10:56 -0800 (PST) MIME-Version: 1.0 References: <20191110204442.GA2865@paulmck-ThinkPad-P72> In-Reply-To: <20191110204442.GA2865@paulmck-ThinkPad-P72> From: Linus Torvalds Date: Sun, 10 Nov 2019 13:10:39 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: KCSAN: data-race in __alloc_file / __alloc_file To: "Paul E. McKenney" Cc: Alan Stern , Marco Elver , Eric Dumazet , Eric Dumazet , syzbot , linux-fsdevel , Linux Kernel Mailing List , syzkaller-bugs , Al Viro , Andrea Parri , LKMM Maintainers -- Akira Yokosawa Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Nov 10, 2019 at 12:44 PM Paul E. McKenney wrote: > > But will "one size fits all" be practical and useful? Oh, I do agree that if KCSAN has some mode where it says "I'll ignore repeated writes with the same value" (or whatever), it could/should likely be behind some flag. I don't think it should be a subsystem flag, though. More of a "I'm willing to actually analyze and ignore false positives" flag. Because I don't think it's so much about the code, as it is about the person who looks at the results. For example, we're already getting push-back from people on some of the KCSAN-inspired patches. If we have people sending patches to add READ_ONCE/WRITE_ONCE to random places to shut up KCSAN reports, I don't think that's good. But if we have people who _work_ on memory ordering issues etc, and want to see a strict mode, knowing there are false positives and able to handle them, that's a completely different thing.. No? Linus