From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Subject: Re: [RFC v3 33/45] nfsd: Keep list of acls to dispose of in compoundargs Date: Thu, 28 May 2015 22:28:13 +0200 Message-ID: References: <4f0168389120bf67cf69ce4ac7bb8ce878aa0f5d.1429868795.git.agruenba@redhat.com> <20150528195205.GC31663@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "J. Bruce Fields" Return-path: In-Reply-To: <20150528195205.GC31663-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org 2015-05-28 21:52 GMT+02:00 J. Bruce Fields : > On Fri, Apr 24, 2015 at 01:04:30PM +0200, Andreas Gruenbacher wrote: >> We will decode acls in requests into richacls; those need to be richacl_put() >> at the end of the request instead of kfree()d; this allows the vfs to cache >> them whenever possible. >> >> NOTE: If we allow only a single acl per request, we can get rid of the list >> here. > > Technically I guess we're supposed to allow it, and maybe someday > someone will come up with a reason.... So I'm not inclined to drop the > list. Okay, I'll update the comment accordingly. Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html