From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 112F6C432C0 for ; Tue, 26 Nov 2019 09:08:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E012F2073F for ; Tue, 26 Nov 2019 09:08:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M7cCrpCr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727305AbfKZJI0 (ORCPT ); Tue, 26 Nov 2019 04:08:26 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:46770 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726346AbfKZJI0 (ORCPT ); Tue, 26 Nov 2019 04:08:26 -0500 Received: by mail-io1-f66.google.com with SMTP id i11so19625614iol.13; Tue, 26 Nov 2019 01:08:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DYoUaVnx+KyGsEJ9h6ubFDzA7o1Y91HlvowSyIB4u6g=; b=M7cCrpCrIZ4LCbZ4UhLXRenmizp3UHCd+p/bh+2mYkjZ6GR4ahA72n3SVUpdsuAvFR psm3NYTD6uX2K9VQ0NOMAk4bO/0VkWe5PJWn38Qfk/ADdSDHuiknaYAY34ZzzXv8nPG8 sq0SbTDToltYVqXZZ83v/cNxwt7Ke1tsHPoW+ehaB5x9zsl6fgymolxzEa0VdqA8BfcN z2vTqzcaZ4bBxvEIintl3J1iMOOGJeD8+RwU9uRvndkyMTfTGR5+ZfjqETQzJ/KR4llJ j3MIwMhmjvV3fcGs/dXIzLyZPdE/ObYxIUbNjX75i9hxf5yUChqGdT/5pJ6XLaZLCK0K RgWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DYoUaVnx+KyGsEJ9h6ubFDzA7o1Y91HlvowSyIB4u6g=; b=oJI0Ohom0Rtzs5YT51Yd77ZoXtAnTXM5NDyRAICqMGfDcWUcD25aAo2JTHRfgg5iU9 dI9SEsB1aUjTJPM5bROG0olsHn7IBAAdAEmGHlyTZUdDGGkGYwzf8iSPsAFAPmsMoirY pwwl4VvhDUjM3nDlIYjwEbU8elxqwBxySTIK+WzI6PyuFvU3ihoZ8l6fEesvGDqAo0sF Sozq2rlnB6DK7LTLrKEfjULkDi2aoTxmX3d8lpyv8H7OPAnoBcSyLraZlH+ZfwGu73lA cwOZVwaWHyrobQvHh2pdqZdDeyVH+0we2gCtb+wCx7mQo2KLHscbqQ9Vi7E8TAUg++01 iA7g== X-Gm-Message-State: APjAAAUj4b086nCzabXTPOVHHjXkAG5SK4FZsNzBWYAuETLsaMlRlZ6D T4baD3dBWu4a5SF/jLGPnCxMrmeGLKnGkgxqfrE= X-Google-Smtp-Source: APXvYqyfjbm1xD9vJMPlCm9jiMuFO96a0z+melj0FGo+2YH0IFHnWzUAVKCPm12COPj5QhPmhZ6Ldd257xh8VpSNgoI= X-Received: by 2002:a02:3403:: with SMTP id x3mr31741578jae.117.1574759303686; Tue, 26 Nov 2019 01:08:23 -0800 (PST) MIME-Version: 1.0 References: <20191122235324.17245-1-agruenba@redhat.com> <20191122235324.17245-4-agruenba@redhat.com> <20191125091508.3265wtfzpoupv2lj@box> In-Reply-To: <20191125091508.3265wtfzpoupv2lj@box> From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Date: Tue, 26 Nov 2019 10:08:12 +0100 Message-ID: Subject: Re: [RFC PATCH 3/3] gfs2: Rework read and page fault locking To: "Kirill A. Shutemov" Cc: Andreas Gruenbacher , Linus Torvalds , Steven Whitehouse , Konstantin Khlebnikov , Linux-MM , Andrew Morton , Linux Kernel Mailing List , Linux FS-devel Mailing List , Alexander Viro , Johannes Weiner , cluster-devel , Ronnie Sahlberg , Steve French , Bob Peterson Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Am Mo., 25. Nov. 2019 um 10:16 Uhr schrieb Kirill A. Shutemov : > On Sat, Nov 23, 2019 at 12:53:24AM +0100, Andreas Gruenbacher wrote: > > @@ -778,15 +804,51 @@ static ssize_t gfs2_file_direct_write(struct kiocb *iocb, struct iov_iter *from) > > > > static ssize_t gfs2_file_read_iter(struct kiocb *iocb, struct iov_iter *to) > > { > > + struct gfs2_inode *ip; > > + struct gfs2_holder gh; > > + size_t written = 0; > > 'written' in a read routine? It's a bit weird, but it's the same as in generic_file_buffered_read. > -- > Kirill A. Shutemov Thanks, Andreas