From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-wr0-f171.google.com ([209.85.128.171]:38512 "EHLO
        mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750913AbeFDQkj (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 4 Jun 2018 12:40:39 -0400
Received: by mail-wr0-f171.google.com with SMTP id 94-v6so44843265wrf.5
        for <linux-fsdevel@vger.kernel.org>; Mon, 04 Jun 2018 09:40:38 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20180604125022.GB30780@lst.de>
References: <20180604123729.23414-1-agruenba@redhat.com> <20180604123729.23414-8-agruenba@redhat.com>
 <20180604125022.GB30780@lst.de>
From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= <andreas.gruenbacher@gmail.com>
Date: Mon, 4 Jun 2018 18:40:37 +0200
Message-ID: <CAHpGcMJnv29kDAp9rMB1twSMrskLGgZcvQXKi0E-etmHvzPUEQ@mail.gmail.com>
Subject: Re: [PATCH v7 07/12] iomap: Add page_write_end iomap hook
To: Christoph Hellwig <hch@lst.de>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
        cluster-devel <cluster-devel@redhat.com>,
        Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

2018-06-04 14:50 GMT+02:00 Christoph Hellwig <hch@lst.de>:
> On Mon, Jun 04, 2018 at 02:37:24PM +0200, Andreas Gruenbacher wrote:
>> Add a page_write_end hook called when done writing to a page, for
>> filesystems that implement data journaling: in that case, pages are
>> written to the journal before being written back to their proper on-disk
>> locations.  The new hook is bypassed for IOMAP_INLINE mappings.
>
> I'd rather not bypass it in common code.  Can you pass the iomap
> to the callback and then do the bypass in gfs2 to keep it generic?

As you wish. You realize we're in extreme bike shed coloring land though, right?

Andreas