From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:41163 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751953AbeFDMDF (ORCPT ); Mon, 4 Jun 2018 08:03:05 -0400 Received: by mail-wr0-f193.google.com with SMTP id h10-v6so1669917wrq.8 for ; Mon, 04 Jun 2018 05:03:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180602170637.GD15847@lst.de> References: <20180602095717.31641-1-agruenba@redhat.com> <20180602095717.31641-6-agruenba@redhat.com> <20180602170637.GD15847@lst.de> From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Date: Mon, 4 Jun 2018 14:03:04 +0200 Message-ID: Subject: Re: [PATCH v6 5/9] iomap: Add write_end iomap operation To: Christoph Hellwig Cc: Andreas Gruenbacher , cluster-devel , Linux FS-devel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: 2018-06-02 19:06 GMT+02:00 Christoph Hellwig : > On Sat, Jun 02, 2018 at 11:57:13AM +0200, Andreas Gruenbacher wrote: >> Add a write_end operation to struct iomap_ops to provide a way of >> overriding the default behavior of iomap_write_end. This will be used >> for implementing data journaling in gfs2: in the data journaling case, >> pages are written into the journal before being written back to their >> proper on-disk locations. > > Please names this page_write_end and make it an optional callout > just for the additional functionality, that is keep the call to > iomap_write_end hardcoded in iomap.c, just call the new method before > it. I'll send an updated patch queue shortly. >> + >> +struct iomap_write_args { >> + const struct iomap_ops *ops; >> + struct iov_iter *iter; >> +}; > > Also I wonder if we should just pass the iomap_ops diretly to the actor > callback. It would make more sense to put the iomap_ops pointer into struct iomap itself. I'll put a patch doing that at the end of my patch queue so you can have a look. Thanks, Andreas