From: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cmaiolino@redhat.com>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Andreas Dilger <adilger@dilger.ca>,
sandeen@redhat.com, Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH 00/10 V2] New ->fiemap infrastructure and ->bmap removal
Date: Mon, 14 Jan 2019 18:56:16 +0100 [thread overview]
Message-ID: <CAHpGcMK5wyLYRxVC9rtVgZ9SrP7XzSVyb78er4U3QD-RaMM1tQ@mail.gmail.com> (raw)
In-Reply-To: <20190114165023.GB7187@lst.de>
Am Mo., 14. Jan. 2019 um 17:50 Uhr schrieb Christoph Hellwig <hch@lst.de>:
> On Fri, Dec 07, 2018 at 10:34:29AM +0100, Carlos Maiolino wrote:
> > On Thu, Dec 06, 2018 at 07:56:02PM +0100, Andreas Grünbacher wrote:
> > > Hi,
> > >
> > > Am Mi., 5. Dez. 2018 um 10:18 Uhr schrieb Carlos Maiolino
> > > <cmaiolino@redhat.com>:
> > > > This is the second version of the complete series with the goal to remove ->bmap
> > > > interface completely, in lieu of FIEMAP.
> > >
> > > I'm not thrilled by this approach. How about exposing the iomap
> > > operations at the vfs layer (for example, in the super block) and
> > > implementing bmap on top of that instead?
> > >
> >
> > Well, the idea is exactly to get rid of bmap, not reimplement it. We can use the
> > same operation for both cases (fiemap+fibmap), so I honestly don't see which
> > advantages would be by reimplementing it.
>
> Exactly. iomap really is a possibly implementation. Everytime we
> exposed implementation details at the ops level that created horrible
> abuses. The most important still relevant example is
> write_begin/write_end, which require fs specific locking but are
> exposed in a way where we can't easily enforce that.
Yes, locking. The fiemap_fill_cb callback hack still makes the fiemap
interface much uglier though. So couldn't the existing iop be used to
fill a kernel buffer in a way similar to what functions like
kernel_readv do? That would at least avoid wrecking an existing
interface.
Thanks,
Andreas
next prev parent reply other threads:[~2019-01-14 17:56 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 9:17 [PATCH 00/10 V2] New ->fiemap infrastructure and ->bmap removal Carlos Maiolino
2018-12-05 9:17 ` [PATCH 01/10] fs: Enable bmap() function to properly return errors Carlos Maiolino
2018-12-05 9:17 ` [PATCH 02/10] cachefiles: drop direct usage of ->bmap method Carlos Maiolino
2018-12-05 9:17 ` [PATCH 03/10] ecryptfs: drop direct calls to ->bmap Carlos Maiolino
2018-12-05 9:17 ` [PATCH 04/10 V2] fibmap: Use bmap instead of ->bmap method in ioctl_fibmap Carlos Maiolino
2019-01-14 16:49 ` Christoph Hellwig
2019-02-04 11:34 ` Carlos Maiolino
2018-12-05 9:17 ` [PATCH 05/10] fs: Move start and length fiemap fields into fiemap_extent_info Carlos Maiolino
2019-01-14 16:50 ` Christoph Hellwig
2018-12-05 9:17 ` [PATCH 06/10] iomap: Remove length and start fields from iomap_fiemap Carlos Maiolino
2019-01-14 16:51 ` Christoph Hellwig
2018-12-05 9:17 ` [PATCH 07/10] fs: Use a void pointer to store fiemap_extent Carlos Maiolino
2019-01-14 16:53 ` Christoph Hellwig
2018-12-05 9:17 ` [PATCH 08/10 V2] fiemap: Use a callback to fill fiemap extents Carlos Maiolino
2019-01-14 16:53 ` Christoph Hellwig
2018-12-05 9:17 ` [PATCH 09/10 V2] Use FIEMAP for FIBMAP calls Carlos Maiolino
2018-12-05 17:36 ` Darrick J. Wong
2018-12-07 9:09 ` Carlos Maiolino
2018-12-07 20:14 ` Andreas Dilger
2019-02-04 15:11 ` Carlos Maiolino
2019-02-04 18:27 ` Darrick J. Wong
2019-02-06 13:37 ` Carlos Maiolino
2019-02-06 20:44 ` Darrick J. Wong
2019-02-06 21:13 ` Andreas Dilger
2019-02-07 9:52 ` Carlos Maiolino
2019-02-08 8:43 ` Christoph Hellwig
2019-02-11 12:57 ` Christoph Hellwig
2019-02-11 16:21 ` Carlos Maiolino
2019-02-11 16:48 ` Christoph Hellwig
2019-02-07 11:59 ` Carlos Maiolino
2019-02-07 17:02 ` Darrick J. Wong
2019-02-07 21:25 ` Andreas Dilger
2019-02-08 8:46 ` Christoph Hellwig
2019-02-08 10:36 ` Carlos Maiolino
2019-02-08 21:03 ` Andreas Dilger
2019-02-08 9:08 ` Carlos Maiolino
2019-02-08 9:03 ` Carlos Maiolino
2019-02-07 12:36 ` Carlos Maiolino
2019-02-07 18:16 ` Darrick J. Wong
2019-02-08 8:58 ` Carlos Maiolino
2019-02-06 21:04 ` Andreas Dilger
2019-01-14 16:56 ` Christoph Hellwig
2019-02-05 9:56 ` Carlos Maiolino
2019-02-05 18:25 ` Christoph Hellwig
2019-02-06 9:50 ` Carlos Maiolino
2018-12-05 9:17 ` [PATCH 10/10] xfs: Get rid of ->bmap Carlos Maiolino
2018-12-05 17:37 ` Darrick J. Wong
2018-12-06 13:06 ` Carlos Maiolino
2018-12-06 18:56 ` [PATCH 00/10 V2] New ->fiemap infrastructure and ->bmap removal Andreas Grünbacher
2018-12-07 9:34 ` Carlos Maiolino
2019-01-14 16:50 ` Christoph Hellwig
2019-01-14 17:56 ` Andreas Grünbacher [this message]
2019-01-14 17:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHpGcMK5wyLYRxVC9rtVgZ9SrP7XzSVyb78er4U3QD-RaMM1tQ@mail.gmail.com \
--to=andreas.gruenbacher@gmail.com \
--cc=adilger@dilger.ca \
--cc=cmaiolino@redhat.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).