From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Subject: Re: [RFC v3 41/45] rpc: Allow to demand-allocate pages to encode into Date: Fri, 29 May 2015 17:46:14 +0200 Message-ID: References: <4bf77d045d2bd3494c695229cd0505b7002cc9a2.1429868795.git.agruenba@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Linux Kernel Mailing List , Linux FS-devel Mailing List , Linux NFS Mailing List To: Trond Myklebust Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org 2015-05-29 1:24 GMT+02:00 Trond Myklebust : > xdr_get_next_encode() should return NULL on failure, not ENOMEM. > Why is this trying to do a GFP_KERNEL allocation inside an XDR routine > anyway? That's not an I/O safe sleep. Fixed, thanks. Andreas