From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: In-Reply-To: From: Salvatore Mesoraca Date: Sun, 16 Sep 2018 18:54:09 +0200 Message-ID: Subject: Re: [PATCH v2 00/10] LSM: Module stacking in support of S.A.R.A and Landlock To: James Morris Cc: casey@schaufler-ca.com, mic@digikod.net, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, john.johansen@canonical.com, keescook@chromium.org, penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com, sds@tycho.nsa.gov, linux-fsdevel@vger.kernel.org, adobriyan@gmail.com, casey.schaufler@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, 12 Sep 2018, James Morris wrote: > Adding the SARA and LandLock authors for review & comment. > > Salvatore & Micka=C3=ABl: does this patchset meet your needs for merging = to > mainline? Since the last time I submitted the patch to the ML, it grew a bit: now it = needs inode's blob stacking (which is already included for Landlock) and kern_ipc_perm's blob stacking. The last one isn't implemented in this patchset, but it isn't absolutely necessary. I can merge a version of SARA that doesn't need it and than update it when possible. I can provide the same level of protection without using kern_ipc_perm blob, I'm using it just to minimize some potential side effects. > > On Tue, 11 Sep 2018, Casey Schaufler wrote: > > > LSM: Module stacking in support of S.A.R.A and Landlock > > > > v2: Reduce the patchset to what is required to support > > the proposed S.A.R.A. and LandLock security modules > > > > The S.A.R.A. security module is intended to be used > > in conjunction with other security modules. It requires > > state to be maintained for the credential, which > > in turn requires a mechanism for sharing the credential > > security blob. The module also requires mechanism for > > user space manipulation of the credential information, > > hence an additional subdirectory in /proc/.../attr. > > > > The LandLock security module provides user configurable > > policy in the secmark mechanism. It requires data in > > the credential, file and inode security blobs. For this > > to be used along side the existing "major" security > > modules mechanism for sharing these blobs is provided. > > > > A side effect of providing sharing of the crendential > > security blob is that the TOMOYO module can be used at > > the same time as the other "major" modules. > > > > The mechanism for configuring which security modules are > > enabled has to change when stacking in enabled. Any > > module that uses just the security blobs that are shared > > can be selected. Additionally, one other "major" module > > can be selected. > > > > The security module stacking issues around networking and > > IPC are not addressed here as they are beyond what is > > required for TOMOYO, S.A.R.A and LandLock. > > > > git://github.com/cschaufler/lsm-stacking.git#stacking-4.19-rc2-saralock > > > > Signed-off-by: Casey Schaufler > > --- > > Documentation/admin-guide/LSM/index.rst | 23 ++- > > fs/proc/base.c | 64 ++++++- > > fs/proc/internal.h | 1 + > > include/linux/lsm_hooks.h | 20 ++- > > include/linux/security.h | 15 +- > > kernel/cred.c | 13 -- > > security/Kconfig | 92 ++++++++++ > > security/apparmor/domain.c | 2 +- > > security/apparmor/include/cred.h | 24 ++- > > security/apparmor/include/file.h | 9 +- > > security/apparmor/include/lib.h | 4 + > > security/apparmor/lsm.c | 53 ++++-- > > security/apparmor/task.c | 6 +- > > security/security.c | 293 ++++++++++++++++++++++++= ++++++-- > > security/selinux/hooks.c | 215 ++++++++--------------- > > security/selinux/include/objsec.h | 37 +++- > > security/selinux/selinuxfs.c | 5 +- > > security/selinux/xfrm.c | 4 +- > > security/smack/smack.h | 42 ++++- > > security/smack/smack_access.c | 4 +- > > security/smack/smack_lsm.c | 283 +++++++++++-------------= ------ > > security/smack/smackfs.c | 18 +- > > security/tomoyo/common.h | 31 +++- > > security/tomoyo/domain.c | 4 +- > > security/tomoyo/securityfs_if.c | 15 +- > > security/tomoyo/tomoyo.c | 57 +++++-- > > 26 files changed, 899 insertions(+), 435 deletions(-) > > > > -- > James Morris >