From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89758C282CE for ; Wed, 24 Apr 2019 17:51:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5813A218B0 for ; Wed, 24 Apr 2019 17:51:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="i2mOYYKH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390307AbfDXRvQ (ORCPT ); Wed, 24 Apr 2019 13:51:16 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:47070 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390745AbfDXR24 (ORCPT ); Wed, 24 Apr 2019 13:28:56 -0400 Received: by mail-io1-f66.google.com with SMTP id p23so16513913iol.13 for ; Wed, 24 Apr 2019 10:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lN83+aUhu5iPVQmRA+/A9ER3XqiY5oN0TOslwMtjELs=; b=i2mOYYKHKNvE3s5wxV1VAY5d1U85VE5dw/XzMQ2N61fnvDiv/r8RJyAEFTcy+bYKeA 5lwLVwQG8U2phsK3lWFRlU7us40i3b2NmJlGZlxl0Q5211N1BmugmPFcDXecbpbvK9m2 q1FUQF8NMqIfNwirokdUznuAaV120kXrz9aD4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lN83+aUhu5iPVQmRA+/A9ER3XqiY5oN0TOslwMtjELs=; b=Cb4bVnyRS5JAxJTNu8BvCQHiQZE75q0DP2eo6XIv3JGGmkHXcBmMuo4YVN9rF/kfvv GYuPkN3UOk8STUCfyweV6UoevtH+SyjM0GKDYPGgUjN6Jb0t3OCh5S+o6Q2Vi14qw7yn HoWSe/TxsvAPc/2ogXEUOznGy69HIW+WKJWHfpUL91H0XqQb6MsDV524TYkk4mKo+WE1 LPLTzfjhRHvj32zbYzL6fw54s/9UArAmMhYtIVMetDWWL89Mon45x6KwvZaVGWHzuVwX QSTkq7uUDWnNmM8jfBbyOeqB5ussoZEPW2vNYp4mrQAGb1zlzI/IFhioUqn+CkUCCYn9 eGRA== X-Gm-Message-State: APjAAAW8/6qO4WdZ7D/TM9jD6ccDco1BqsceIIix0tgHOKQfwqzOLbRi FPE4CI4+iGOlsEY/fEjgJoTOdaojNlSKRj6hWxWiL89l X-Google-Smtp-Source: APXvYqz3cHuXu+wqxN0CPQ6FM2nAGgKq5onzw0iCS/4eLtfmBsY/d8KPFbc2/hMU5jji5J7RO/3qfdGuighQlaMzSnI= X-Received: by 2002:a5e:8202:: with SMTP id l2mr18783581iom.144.1556126935594; Wed, 24 Apr 2019 10:28:55 -0700 (PDT) MIME-Version: 1.0 References: <155372999953.7602.13784796495137723805.stgit@warthog.procyon.org.uk> <155373036414.7602.7964458548629410897.stgit@warthog.procyon.org.uk> <3217.1556119323@warthog.procyon.org.uk> In-Reply-To: <3217.1556119323@warthog.procyon.org.uk> From: Miklos Szeredi Date: Wed, 24 Apr 2019 19:28:44 +0200 Message-ID: Subject: Re: [RFC PATCH 44/68] vfs: Convert fuse to use the new mount API To: David Howells Cc: Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Apr 24, 2019 at 5:22 PM David Howells wrote: > > Miklos Szeredi wrote: > > > Should I be applying this, together with the vfs dependencies? Or > > will you take care of these? > > I'm hoping Al will take the entire series. > > > One minor comment is that fuse conventionally uses "struct fuse_conn > > *fc", so "struct fs_context *fc" is confusing here. There's one place > > you use "struct fs_context *fsc", which seems the right thing to do > > for all the cases. > > Except in ceph, where "struct ceph_fs_client *fsc" is a common thing... I'd be happy if it was consistently "struct fs_context *fsc" in just fuse/inode.c. Thanks, Miklos