From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f67.google.com ([209.85.218.67]:41658 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754044AbeFKJP4 (ORCPT ); Mon, 11 Jun 2018 05:15:56 -0400 Received: by mail-oi0-f67.google.com with SMTP id a141-v6so17224329oii.8 for ; Mon, 11 Jun 2018 02:15:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180610060159.GS30522@ZenIV.linux.org.uk> References: <20180529144143.16378-1-mszeredi@redhat.com> <20180529144143.16378-10-mszeredi@redhat.com> <20180610054902.GQ30522@ZenIV.linux.org.uk> <20180610060159.GS30522@ZenIV.linux.org.uk> From: Miklos Szeredi Date: Mon, 11 Jun 2018 11:15:55 +0200 Message-ID: Subject: Re: [PATCH 09/11] vfs: factor out inode_insert5() To: Al Viro Cc: Miklos Szeredi , overlayfs , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Jun 10, 2018 at 8:02 AM, Al Viro wrote: > On Sun, Jun 10, 2018 at 06:49:10AM +0100, Al Viro wrote: >> On Tue, May 29, 2018 at 04:41:41PM +0200, Miklos Szeredi wrote: >> > From: Miklos Szeredi >> > >> > Split out common helper for race free insertion of an already allocated >> > inode into the cache. Use this from iget5_locked() and >> > insert_inode_locked4(). Make iget5_locked() use new_inode()/iput() instead >> > of alloc_inode()/destroy_inode() directly. >> >> ... thus hitting the sucker with ->evict_inode(), in condition that is quite >> likely to be unfit to be seen by that. >> >> NAK. > > To clarify: objection here is against the switch to new_inode/iput. The rest is > sane. What makes new_inode() better here, anyway? Umm, got to look into this. The patch has already been pulled by Linus, but I hope it's salvageable. Thanks, Miklos