From: Miklos Szeredi <miklos@szeredi.hu>
To: wangyan <wangyan122@huawei.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
linux-fsdevel@vger.kernel.org,
"virtio-fs@redhat.com" <virtio-fs@redhat.com>,
Miklos Szeredi <mszeredi@redhat.com>
Subject: Re: [Virtio-fs] [QUESTION] A performance problem for buffer write compared with 9p
Date: Thu, 22 Aug 2019 13:43:27 +0200 [thread overview]
Message-ID: <CAJfpegtBYLJLWM8GJ1h66PMf2J9o38FG6udcd2hmamEEQddf5w@mail.gmail.com> (raw)
In-Reply-To: <954b5f8a-4007-f29c-f38e-dd5585879541@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
On Thu, Aug 22, 2019 at 2:59 AM wangyan <wangyan122@huawei.com> wrote:
> I will test it when I get the patch, and post the compared result with
> 9p.
Could you please try the attached patch? My guess is that it should
improve the performance, perhaps by a big margin.
Further improvement is possible by eliminating page copies, but that
is less trivial.
Thanks,
Miklos
[-- Attachment #2: virtio-fs-nostrict.patch --]
[-- Type: text/x-patch, Size: 511 bytes --]
Index: linux/fs/fuse/virtio_fs.c
===================================================================
--- linux.orig/fs/fuse/virtio_fs.c 2019-08-22 13:38:31.782833564 +0200
+++ linux/fs/fuse/virtio_fs.c 2019-08-22 13:37:55.436406261 +0200
@@ -891,6 +891,9 @@ static int virtio_fs_fill_super(struct s
if (err < 0)
goto err_free_init_req;
+ /* No strict accounting needed for virtio-fs */
+ sb->s_bdi->capabilities = 0;
+
fc = fs->vqs[VQ_REQUEST].fud->fc;
/* TODO take fuse_mutex around this loop? */
next prev parent reply other threads:[~2019-08-22 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 0:30 [QUESTION] A performance problem for buffer write compared with 9p wangyan
2019-08-15 0:56 ` Gao Xiang
2019-08-20 9:16 ` [Virtio-fs] " Stefan Hajnoczi
2019-08-21 7:51 ` Miklos Szeredi
2019-08-21 16:05 ` Stefan Hajnoczi
2019-08-22 0:59 ` wangyan
2019-08-22 11:43 ` Miklos Szeredi [this message]
2019-08-22 12:48 ` wangyan
2019-08-22 13:07 ` Miklos Szeredi
2019-08-22 13:17 ` wangyan
2019-08-22 13:29 ` Miklos Szeredi
2019-08-22 14:02 ` Miklos Szeredi
[not found] ` <fd7a2791-d95c-3bd9-e387-b8778a9eca83@huawei.com>
2019-08-26 12:39 ` Miklos Szeredi
2019-08-28 0:57 ` wangyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegtBYLJLWM8GJ1h66PMf2J9o38FG6udcd2hmamEEQddf5w@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=wangyan122@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).