From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C945C48BDF for ; Thu, 10 Jun 2021 12:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33BA0613DF for ; Thu, 10 Jun 2021 12:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230248AbhFJMoU (ORCPT ); Thu, 10 Jun 2021 08:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbhFJMoT (ORCPT ); Thu, 10 Jun 2021 08:44:19 -0400 Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72D5DC061760 for ; Thu, 10 Jun 2021 05:42:23 -0700 (PDT) Received: by mail-ua1-x935.google.com with SMTP id f34so1226818uae.4 for ; Thu, 10 Jun 2021 05:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=bWmonaOQtQnoMrqggNjQmbBLp/OFsefkhaXRpT3N30oDxasxyxX5+zHqOhyxg8TwQ1 9WhDWldZuNugQzNq9CRVa79/7odXcgVZfZJpa4jozV3UwwVJh+rViZAq1j+cqvO83+lk Ul0lp34cK0STCoHisDcJwkiJqPEl1W1Jca9Ac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=mFlbFW+w1ZLC+84Qb7aOlz4/zqaJNB3WuYs0lk7a36+IB9H3aqfTw9s+riQRgQaJmG DZ3jHGfozY9sal3w+6CUvYbbD/7KcoG645cC4t0TdPyPIqIkyF5ru0sGIf/sQWMJPOuo z0NnTnTytgK0zeG6njvSKTLdbMHMwECyI8F94U9X92vFxrEVT7S/ZtjtrfbyG937JX6h kNgbvlqQXdlSe/rEae3k9RD24R8/M9hEWsRanoJa9oEvItkhsnyQn4tvHPgsi4S7Vxy4 r07Osr1dq6+h67FrFvd5UwMyfnlVAIIaSskmHVyK3mEqi9OTFUbyDt0oKePruPgvclOQ aXYQ== X-Gm-Message-State: AOAM533hH9d48Gi9IS1bT9rJUIex24JPwdDIY7F/r5cjYsUFRN6Bq/uC 3lMxC+N2qQHYKlqZPt5SwBjcIJFAAH0YjxHuWCgtNQ== X-Google-Smtp-Source: ABdhPJzSnBnKZyOmEQg1Mlk1J3k9vxKYbX0hKrYXjQBdDrHZwFo89gBvp5Cl9ryn+jRW8T0jKkHsp9O4DmV9/7gYf0I= X-Received: by 2002:ab0:2690:: with SMTP id t16mr4105093uao.9.1623328942641; Thu, 10 Jun 2021 05:42:22 -0700 (PDT) MIME-Version: 1.0 References: <20210607144631.8717-1-jack@suse.cz> <20210607145236.31852-12-jack@suse.cz> In-Reply-To: <20210607145236.31852-12-jack@suse.cz> From: Miklos Szeredi Date: Thu, 10 Jun 2021 14:42:12 +0200 Message-ID: Subject: Re: [PATCH 12/14] fuse: Convert to using invalidate_lock To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , CIFS , Ext4 , linux-f2fs-devel@lists.sourceforge.net, linux-mm , linux-xfs , Steve French , Ted Tso , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, 7 Jun 2021 at 16:52, Jan Kara wrote: > > Use invalidate_lock instead of fuse's private i_mmap_sem. The intended > purpose is exactly the same. By this conversion we fix a long standing > race between hole punching and read(2) / readahead(2) paths that can > lead to stale page cache contents. > > CC: Miklos Szeredi > Signed-off-by: Jan Kara Reviewed-by: Miklos Szeredi Thanks, Miklos