* [PATCH] fuse: redundant get_fuse_inode() calls in fuse_writepages_fill()
@ 2019-08-19 5:48 Vasily Averin
2019-10-03 8:21 ` Miklos Szeredi
0 siblings, 1 reply; 2+ messages in thread
From: Vasily Averin @ 2019-08-19 5:48 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, Miklos Szeredi
Currently fuse_writepages_fill() calls get_fuse_inode() few times with
the same argument.
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
fs/fuse/file.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index e076c2cf65b0..bc9b64ef7b5d 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1874,7 +1874,7 @@ static int fuse_writepages_fill(struct page *page,
if (!data->ff) {
err = -EIO;
- data->ff = fuse_write_file_get(fc, get_fuse_inode(inode));
+ data->ff = fuse_write_file_get(fc, fi);
if (!data->ff)
goto out_unlock;
}
@@ -1919,8 +1919,6 @@ static int fuse_writepages_fill(struct page *page,
* under writeback, so we can release the page lock.
*/
if (data->req == NULL) {
- struct fuse_inode *fi = get_fuse_inode(inode);
-
err = -ENOMEM;
req = fuse_request_alloc_nofs(FUSE_REQ_INLINE_PAGES);
if (!req) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fuse: redundant get_fuse_inode() calls in fuse_writepages_fill()
2019-08-19 5:48 [PATCH] fuse: redundant get_fuse_inode() calls in fuse_writepages_fill() Vasily Averin
@ 2019-10-03 8:21 ` Miklos Szeredi
0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2019-10-03 8:21 UTC (permalink / raw)
To: Vasily Averin; +Cc: linux-kernel, linux-fsdevel
On Mon, Aug 19, 2019 at 7:48 AM Vasily Averin <vvs@virtuozzo.com> wrote:
>
> Currently fuse_writepages_fill() calls get_fuse_inode() few times with
> the same argument.
Thanks, applied.
Miklos
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-03 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 5:48 [PATCH] fuse: redundant get_fuse_inode() calls in fuse_writepages_fill() Vasily Averin
2019-10-03 8:21 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).