From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E20C43331 for ; Fri, 6 Sep 2019 08:15:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 733BD206A1 for ; Fri, 6 Sep 2019 08:15:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="mOY+F7Io" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389171AbfIFIP0 (ORCPT ); Fri, 6 Sep 2019 04:15:26 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:34970 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733020AbfIFIPZ (ORCPT ); Fri, 6 Sep 2019 04:15:25 -0400 Received: by mail-io1-f67.google.com with SMTP id f4so10137820ion.2 for ; Fri, 06 Sep 2019 01:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=71+P9Y1aQOgw6Dp9fK4XNoBcCfSmpfYHfETpowIUBEc=; b=mOY+F7IoXze5/oEY9qnxW4BtDV3c6OGnOM65rcAz4tBQ+pP1oCmZx3kBCsHFdm9ssi tdD9aqu1qDCinK7SZKtFdQ7WsDaXA5OVnxl3jnwgL/Rl00M0BEsmJ/uoAk72kSFu5qei FYQzoLZKR/w9+CtVp9n067d669r/fYv2PpYlk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=71+P9Y1aQOgw6Dp9fK4XNoBcCfSmpfYHfETpowIUBEc=; b=tAnRpTy+JdXAqj5n3e7XAPV2NZ6/odSrE5NB9dZUbUe54oL8KOPOr3qyx50ieWdB1C fkOmJ5EIMWqsRTx34GUydyhsnKO5Y6HEEsCm+vd3cTaOYqP1jDLG1QWPTh+GiPuUpadl 4PaB3XQM4wnDOV484tSywBBvQytNscv1xf6ie2VXTlQUtBYBjB2iQ6dNNSinm+Dz3+3n gbOjy6e2HCI2kpq5gi6Jupei1vyMaLECe/sSIB5MZSfB7rHBc0Fd6RhJ4zGDK7VlP+8y QwWjWTEZYCU8+peHOysFf+Gfh+Tq3BxjJD6IvfaHTcfZt5DSu8Z+DtTTI669idziUk1n ejbA== X-Gm-Message-State: APjAAAUFJO4iHNdzZfcQmnyg1qiNEHVaoz+XoGlNRN0txgxx6YzF++20 HEmPeNEstcWL5OZYwZezufsloDj2Po+9yersWGqfRlqd X-Google-Smtp-Source: APXvYqzMtxa4XtA7wApmndxSDp7Bu8ZqzrPn0Tms4HAAjPUjMhyeA/vR5U1wZspaH+eF6zgoriVn3BWfEXcffE6I7Is= X-Received: by 2002:a6b:bec6:: with SMTP id o189mr8631585iof.62.1567757724963; Fri, 06 Sep 2019 01:15:24 -0700 (PDT) MIME-Version: 1.0 References: <20190905194859.16219-1-vgoyal@redhat.com> In-Reply-To: <20190905194859.16219-1-vgoyal@redhat.com> From: Miklos Szeredi Date: Fri, 6 Sep 2019 10:15:14 +0200 Message-ID: Subject: Re: [PATCH 00/18] virtiofs: Fix various races and cleanups round 1 To: Vivek Goyal Cc: linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, Stefan Hajnoczi , "Dr. David Alan Gilbert" , "Michael S. Tsirkin" Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal wrote: > > Hi, > > Michael Tsirkin pointed out issues w.r.t various locking related TODO > items and races w.r.t device removal. > > In this first round of cleanups, I have taken care of most pressing > issues. > > These patches apply on top of following. > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4 > > I have tested these patches with mount/umount and device removal using > qemu monitor. For example. Is device removal mandatory? Can't this be made a non-removable device? Is there a good reason why removing the virtio-fs device makes sense? Thanks, Miklos