linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Peng Hao <flyingpenghao@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fuse: fix possible write position calculation error
Date: Thu, 4 Nov 2021 13:17:50 +0100	[thread overview]
Message-ID: <CAJfpeguWtPFG_daMNA7=T-kQmgkcTPugMj7HWhh2mu+cwRWbxw@mail.gmail.com> (raw)
In-Reply-To: <20211103011527.42711-1-flyingpeng@tencent.com>

On Wed, 3 Nov 2021 at 02:15, Peng Hao <flyingpenghao@gmail.com> wrote:
>
> The 'written' that generic_file_direct_write return through
> filemap_write_and_wait_range is not necessarily sequential,
> and its iocb->ki_pos has not been updated.

I don't see the bug, but maybe I'm missing something.  Can you please
explain in detail?

The patch looks good as a cleanup, but I'd very much like to know
first if it fixes a bug or not.

Thanks,
Miklos

  reply	other threads:[~2021-11-04 12:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03  1:15 [PATCH] fuse: fix possible write position calculation error Peng Hao
2021-11-04 12:17 ` Miklos Szeredi [this message]
2021-11-05  7:43   ` Hao Peng
2021-11-10 10:40     ` Miklos Szeredi
2021-11-11  1:40       ` Hao Peng
  -- strict thread matches above, loose matches on Subject: below --
2021-10-26  2:34 Peng Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpeguWtPFG_daMNA7=T-kQmgkcTPugMj7HWhh2mu+cwRWbxw@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=flyingpenghao@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).