From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f196.google.com ([74.125.82.196]:44477 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935918AbeE3I2z (ORCPT ); Wed, 30 May 2018 04:28:55 -0400 Received: by mail-ot0-f196.google.com with SMTP id g7-v6so20165557otj.11 for ; Wed, 30 May 2018 01:28:55 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20180529144143.16378-1-mszeredi@redhat.com> <20180529144143.16378-6-mszeredi@redhat.com> From: Miklos Szeredi Date: Wed, 30 May 2018 10:28:54 +0200 Message-ID: Subject: Re: [PATCH 05/11] ovl: return dentry from ovl_create_real() To: Amir Goldstein Cc: Miklos Szeredi , overlayfs , linux-fsdevel , linux-kernel , Al Viro Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, May 29, 2018 at 5:24 PM, Amir Goldstein wrote: > On Tue, May 29, 2018 at 5:41 PM, Miklos Szeredi wrote: >> From: Amir Goldstein >> >> Al Viro suggested to simplify callers of ovl_create_real() by >> returning the created dentry (or ERR_PTR) from ovl_create_real(). >> This prep patch makes Al's patch change less callers. >> >> Also used ovl_create_temp() in ovl_create_index() instead of calling >> ovl_do_mkdir() directly, so now all callers of ovl_do_mkdir() are routed >> through ovl_create_real(), which paves the way for Al's fix for non-hashed >> result from vfs_mkdir(). >> > > It's good that you split this patch from ovl_create_temp() patch, but > the commit message it utterly not related to the patch anymore and > possibly should retain Al's authorship cause there is no relic of my > work in this patch. Fixed headers and authorship assignments. Thanks, Miklos