From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A38BC43331 for ; Fri, 6 Sep 2019 11:52:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAC59214DE for ; Fri, 6 Sep 2019 11:52:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="M6kMLhhr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391144AbfIFLwx (ORCPT ); Fri, 6 Sep 2019 07:52:53 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:38242 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391142AbfIFLwx (ORCPT ); Fri, 6 Sep 2019 07:52:53 -0400 Received: by mail-io1-f66.google.com with SMTP id p12so12063606iog.5 for ; Fri, 06 Sep 2019 04:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f4lqVL9E8teUhvToTgEeuMgi3bTyCtYt4jpvCxfm54Q=; b=M6kMLhhrR1rSwxoyoRq92O56PaUv4DjhHtEi23Zna8X3y6GiVStVcgzJOPeB9P6X1d DdVtzL1OUc3LB71I/dqAOxlGGmrNQpZB504ocPjGN3JGQcl6Ax9TqTmWb1ESVc1DoXwK B46n8m+4HwmtG0XpBl9stwF9MkxMcUuN6wozQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f4lqVL9E8teUhvToTgEeuMgi3bTyCtYt4jpvCxfm54Q=; b=f+aAWLs3o7+oPPbUEuH6HmkfZEuIoIFL4XYIkDlaIXfXLuWKt4wTu6vWus0M/jGNoJ ytxFkxNpTxfkUDfZ64i9lr4aSXUQa74NAEhqL15IjMrG+73bd9QDq13fxvyFduhFJOfc Rn8FSKARWMfjTvrt12Dpu7mvJaL/WLjuW8FhZk9Jmmb2YH5iOJMwi65qdY2MCygbkSYH iem/59+iWGdFu48CwWsuqlYIxmy9Cg3PBFDlL1qOo+tZ+R5Zn/vPTH7haQWwo0sBEpto jH2JRCdURoYdPtzwGcv2HDErwZ2s6EENmrv+SmWsIacOWCr3R/MnMnasch4BE+dVkHRN hVdg== X-Gm-Message-State: APjAAAUPm8L7dLwqXZCoL2zzdJeiVyizHKmeGkY7ZHGygIkfNO/gFTRA ReydVsYAR2YckkpknsmDAwSvn4fa9A3PqDEIYdhuJw== X-Google-Smtp-Source: APXvYqzDqDUnTf7efWqCw8eAeZPl2HmDPoN7CDauAbzjCHdo6rqOXrTSpwAa3PZ379dVg7Ek5PStHiGrSfwEhZLZgpo= X-Received: by 2002:a5e:d70b:: with SMTP id v11mr701415iom.252.1567770772377; Fri, 06 Sep 2019 04:52:52 -0700 (PDT) MIME-Version: 1.0 References: <20190905194859.16219-1-vgoyal@redhat.com> <20190906103613.GH5900@stefanha-x1.localdomain> In-Reply-To: <20190906103613.GH5900@stefanha-x1.localdomain> From: Miklos Szeredi Date: Fri, 6 Sep 2019 13:52:41 +0200 Message-ID: Subject: Re: [PATCH 00/18] virtiofs: Fix various races and cleanups round 1 To: Stefan Hajnoczi Cc: Vivek Goyal , linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, "Dr. David Alan Gilbert" , "Michael S. Tsirkin" Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi wrote: > > On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > > On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal wrote: > > > > > > Hi, > > > > > > Michael Tsirkin pointed out issues w.r.t various locking related TODO > > > items and races w.r.t device removal. > > > > > > In this first round of cleanups, I have taken care of most pressing > > > issues. > > > > > > These patches apply on top of following. > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4 > > > > > > I have tested these patches with mount/umount and device removal using > > > qemu monitor. For example. > > > > Is device removal mandatory? Can't this be made a non-removable > > device? Is there a good reason why removing the virtio-fs device > > makes sense? > > Hot plugging and unplugging virtio PCI adapters is common. I'd very > much like removal to work from the beginning. Can you give an example use case? Thanks, Miklos