From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E16BC433E1 for ; Thu, 16 Jul 2020 05:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0C7C204EC for ; Thu, 16 Jul 2020 05:17:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="b1LEFcnR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725913AbgGPFRs (ORCPT ); Thu, 16 Jul 2020 01:17:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbgGPFRs (ORCPT ); Thu, 16 Jul 2020 01:17:48 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFC96C061755 for ; Wed, 15 Jul 2020 22:17:47 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id ga4so5203167ejb.11 for ; Wed, 15 Jul 2020 22:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nhKdkyhzBCrHDBJwUUcPf+KwT6tO1Wi+tMUkn7td2RQ=; b=b1LEFcnRYx1nTMkOSj0eTB/2U15B9GIWDLABwl6F+4oXlXbNreUFFzUVlzRmtbZH/W zEWxLPDgqjA61HLvxaZ9e4ueIt3ocMzY1cHVlZXTlS5SDYZuedDggNjvXdr/fBmtRWPy IDSyjQDt6/FnzYzq7AU4G/iOD6Z2hM4bUWXUE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nhKdkyhzBCrHDBJwUUcPf+KwT6tO1Wi+tMUkn7td2RQ=; b=k4dYw61ikE83z7x9UE+OVE43xE9AFN92Dxt6h23Shb4Mdgv7dLW01KMqfhBgVpAjmF aJKFiQqcuKinVmpRx60dxxYL4JQ5C85F4ssNdkH05YA4gnMO3wqgzQ3mvTUU58fkPmx5 cQeDzDi0m4f+sUphp3Itm6Jbe4vjjkRivZPAJtwORnQx9P7JWXwFA+zP+bFqmu9VRO1Z NZVvQxlPjRGjo2eEV69LmaDa6aUKXsNCjhEB38nglIPCAbUPVFRDCDtbdGyFFE22DQO6 /ovATHsGTwedkVCP3Ixp2SatgTSjI10Os+4+yJWBcAvqcpD5scdl4LcvpBktWh8iH0A1 OkRw== X-Gm-Message-State: AOAM532gVY95tptik1RjKCGGdQw3DnwdJytbOuAMKXAHkv61KPZ807f3 IjH3iqPljekA4Cad9UK5uuRPU42mHAMxJg2g/amKzg== X-Google-Smtp-Source: ABdhPJwR08O0tTC70WK+dzUYKsRlUldZiUJ9by9ozP6Qb0JMiLS/i4upeHK3NPcl15T56c1fTQWRZ8W5qEvKKyNMrcI= X-Received: by 2002:a17:906:3c42:: with SMTP id i2mr2339121ejg.14.1594876666485; Wed, 15 Jul 2020 22:17:46 -0700 (PDT) MIME-Version: 1.0 References: <20200714102639.662048-1-chirantan@chromium.org> In-Reply-To: From: Miklos Szeredi Date: Thu, 16 Jul 2020 07:17:35 +0200 Message-ID: Subject: Re: [PATCH] fuse: Fix parameter for FS_IOC_{GET,SET}FLAGS To: Sedat Dilek Cc: Chirantan Ekbote , linux-fsdevel@vger.kernel.org, Dylan Reid , Suleiman Souhlal , fuse-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jul 16, 2020 at 1:06 AM Sedat Dilek wrote: > > On Wed, Jul 15, 2020 at 5:05 PM Miklos Szeredi wrote: > > > > On Tue, Jul 14, 2020 at 12:26 PM Chirantan Ekbote > > wrote: > > > > > > The ioctl encoding for this parameter is a long but the documentation > > > says it should be an int and the kernel drivers expect it to be an int. > > > If the fuse driver treats this as a long it might end up scribbling over > > > the stack of a userspace process that only allocated enough space for an > > > int. > > > > > > This was previously discussed in [1] and a patch for fuse was proposed > > > in [2]. From what I can tell the patch in [2] was nacked in favor of > > > adding new, "fixed" ioctls and using those from userspace. However > > > there is still no "fixed" version of these ioctls and the fact is that > > > it's sometimes infeasible to change all userspace to use the new one. > > > > Okay, applied. > > > > ...and pushed? I do not see in in fuse.git. Pushed now. Thanks, Miklos