linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tigran Aivazian <aivazian.tigran@gmail.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org,
	syzbot <syzbot+71c6b5d68e91149fc8a4@syzkaller.appspotmail.com>,
	syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: [PATCH] bfs: add sanity check at bfs_fill_super().
Date: Wed, 13 Jun 2018 14:49:32 +0100	[thread overview]
Message-ID: <CAK+_RLko_OCepN4FCmsaQPAKkt9JNGe8pNRK7SO-onhw5zCneA@mail.gmail.com> (raw)
In-Reply-To: <9ef86114-02d6-b243-203d-fbbdab95a6fa@I-love.SAKURA.ne.jp>

Having read the discussion carefully, I personally prefer to ignore
the fix as invalid, because mounting a filesystem image is a
privileged operation and if attempting to mount a corrupted image
causes a panic, that is no big deal, imho.

On 13 June 2018 at 14:33, Tetsuo Handa
<penguin-kernel@i-love.sakura.ne.jp> wrote:
> On 2018/05/10 8:53, Andrew Morton wrote:
>> On Thu, 10 May 2018 08:46:18 +0900 Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote:
>>
>>>> page-allocation-fauilure warning and a nice backtrace, etc.  Why
>>>> suppress all of that and add our custom warning instead?
>>>
>>> the intent of this patch is to avoid panic() by panic_on_warn == 1
>>> due to hitting
>>>
>>> struct kmem_cache *kmalloc_slab(size_t size, gfp_t flags)
>>> {
>>>         unsigned int index;
>>>
>>>         if (unlikely(size > KMALLOC_MAX_SIZE)) {
>>>                 WARN_ON_ONCE(!(flags & __GFP_NOWARN)); /* <= this line */
>>>                 return NULL;
>>>         }
>>>
>>> when size to allocate is controlled by the filesystem image.
>>
>> Well, the same could happen with many many memory-allocation sites.
>> What's special about BFS?  If someone sets panic_on_warn=1 then
>> presumably this panic is the behaviour they wanted in this case.
>>
>
> Tigran, this patch is stalling. Do we want to apply this? Or, ignore as invalid?
>
> errors=panic mount option for ext4 case was ignored as invalid.
> http://lkml.kernel.org/r/CACT4Y+Z+2YW_VALJzzQr6hLsviA=dXk3iFqwVf+P5zqojeC9Zg@mail.gmail.com
>
> But I prefer avoiding crashes if we can fix it.

  reply	other threads:[~2018-06-13 13:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 10:35 [PATCH] bfs: add sanity check at bfs_fill_super() Tetsuo Handa
2018-05-09 23:06 ` Andrew Morton
     [not found]   ` <201805092346.w49NkINl045657@www262.sakura.ne.jp>
2018-05-09 23:53     ` Andrew Morton
2018-06-13 13:33       ` Tetsuo Handa
2018-06-13 13:49         ` Tigran Aivazian [this message]
2018-06-13 16:00           ` Dmitry Vyukov
2018-06-14 12:23             ` Tigran Aivazian
2018-06-14 12:38               ` Dmitry Vyukov
2018-06-14 13:05                 ` Tigran Aivazian
2018-06-14 13:12                   ` Dmitry Vyukov
2018-06-14 13:28                   ` Tetsuo Handa
2018-06-14 15:13                     ` Tigran Aivazian
2018-06-14 16:15                       ` Tigran Aivazian
2018-06-14 19:00                         ` Tigran Aivazian
2018-06-14 22:18                           ` Tetsuo Handa
2018-06-15 10:45                             ` Tigran Aivazian
2018-06-13 22:09           ` Tetsuo Handa
2018-06-14  7:38             ` Tigran Aivazian
2018-06-14 10:45               ` Tetsuo Handa
2018-06-14 12:11                 ` Tigran Aivazian
2018-05-10  0:53 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK+_RLko_OCepN4FCmsaQPAKkt9JNGe8pNRK7SO-onhw5zCneA@mail.gmail.com \
    --to=aivazian.tigran@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=syzbot+71c6b5d68e91149fc8a4@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).