From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:36990 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbeEPJpf (ORCPT ); Wed, 16 May 2018 05:45:35 -0400 Received: by mail-wr0-f193.google.com with SMTP id h5-v6so190528wrm.4 for ; Wed, 16 May 2018 02:45:35 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180513213017.31269-1-viro@ZenIV.linux.org.uk> References: <20180513212612.GV30522@ZenIV.linux.org.uk> <20180513213017.31269-1-viro@ZenIV.linux.org.uk> From: Tigran Aivazian Date: Wed, 16 May 2018 10:45:34 +0100 Message-ID: Subject: Re: [PATCH 01/15] bfs_lookup(): use d_splice_alias() To: Al Viro Cc: linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Al, Thank you. This feels a bit like a "time machine", i.e. being instantly transferred to the almost forgotten distant past for the joy of seeing familiar faces. Well, past, present or future --- Al Viro is always right (especially as far as filesystems' code is concerned) and I safely defer to you --- if you say it is better, then it most certainly is, dear friend. And to me it looks better too. Kind regards, Tigran On 13 May 2018 at 22:30, Al Viro wrote: > From: Al Viro > > code is actually simpler that way. > > Cc: "Tigran A. Aivazian" > Signed-off-by: Al Viro > --- > fs/bfs/dir.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c > index ee832ca5f734..facf9614a381 100644 > --- a/fs/bfs/dir.c > +++ b/fs/bfs/dir.c > @@ -141,14 +141,9 @@ static struct dentry *bfs_lookup(struct inode *dir, struct dentry *dentry, > unsigned long ino = (unsigned long)le16_to_cpu(de->ino); > brelse(bh); > inode = bfs_iget(dir->i_sb, ino); > - if (IS_ERR(inode)) { > - mutex_unlock(&info->bfs_lock); > - return ERR_CAST(inode); > - } > } > mutex_unlock(&info->bfs_lock); > - d_add(dentry, inode); > - return NULL; > + return d_splice_alias(inode, dentry); > } > > static int bfs_link(struct dentry *old, struct inode *dir, > -- > 2.11.0 >