From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BC2AC433FF for ; Wed, 31 Jul 2019 15:47:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB521206B8 for ; Wed, 31 Jul 2019 15:47:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729069AbfGaPrw (ORCPT ); Wed, 31 Jul 2019 11:47:52 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:38105 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727349AbfGaPrv (ORCPT ); Wed, 31 Jul 2019 11:47:51 -0400 Received: by mail-qt1-f193.google.com with SMTP id n11so67033681qtl.5; Wed, 31 Jul 2019 08:47:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=83OSe7y2aU72IIQHUhZp7X/NaI9ahxBDb1zvEgcPWYg=; b=stvDV/xL+VOq1KnvigR23c8LqadzJBpq7gku4pd7eBzYzbbd74+SNY3tPA5WvVQuTy SGzXMdHLU3ITXUfPgnhC3hCyCwOYgDfgl+izJPjZMUTEnCxMrfeS7tpb4spbzl50hAIR zROeaUOOaBW58TSR7H6lLtUyOIBdu23oM7N/4bwba05eCWZd26W4QGbJ5j9gMWUeD2ZJ fDIPs3UBfdppH7m4v3bEAOzgLoTVqJeDdWhKVF4DtGO4rfHMNYooFf8g/paKicylCcG1 B3ikbi1liLsYSnXro7cJrqYRVmUebEqfmexBfPczc4xVkQ8UgxnADFA9etLFevPz0vOS kSVw== X-Gm-Message-State: APjAAAVNGbix6pwlmZtLTjVqNjHbcdKw8d1VJMX0GN8PMvzxOPxRhVGF I0jOA8GZUn+cbDEpm7HHO2liQRYDtaBP682FQN0= X-Google-Smtp-Source: APXvYqyxedT2V2Y2ueteq5CdjTWcyt+qnzC20u56SIyvSN4Tvj+mYfIXi7Eg+U3QdqrIQo3qfLl+9AJWummnynXCsSA= X-Received: by 2002:a0c:b758:: with SMTP id q24mr88044697qve.45.1564588070611; Wed, 31 Jul 2019 08:47:50 -0700 (PDT) MIME-Version: 1.0 References: <20190730192552.4014288-1-arnd@arndb.de> <20190730195819.901457-1-arnd@arndb.de> <20190730195819.901457-3-arnd@arndb.de> <20190731105039.GB3488@osiris> In-Reply-To: <20190731105039.GB3488@osiris> From: Arnd Bergmann Date: Wed, 31 Jul 2019 17:47:33 +0200 Message-ID: Subject: Re: [PATCH v5 15/29] compat_ioctl: move tape handling into drivers To: Heiko Carstens Cc: Alexander Viro , Linux FS-devel Mailing List , Linux Kernel Mailing List , "David S. Miller" , Vasily Gorbik , Christian Borntraeger , =?UTF-8?Q?Kai_M=C3=A4kisara?= , "James E.J. Bottomley" , "Martin K. Petersen" , IDE-ML , linux-s390 , linux-scsi Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jul 31, 2019 at 12:51 PM Heiko Carstens wrote: > > On Tue, Jul 30, 2019 at 09:55:31PM +0200, Arnd Bergmann wrote: > > MTIOCPOS and MTIOCGET are incompatible between 32-bit and 64-bit user > > space, and traditionally have been translated in fs/compat_ioctl.c. > > > > To get rid of that translation handler, move a corresponding > > implementation into each of the four drivers implementing those commands. > > > > The interesting part of that is now in a new linux/mtio.h header that > > wraps the existing uapi/linux/mtio.h header and provides an abstraction > > to let drivers handle both cases easily. Using an in_compat_syscall() > > check, the caller does not have to keep track of whether this was > > called through .unlocked_ioctl() or .compat_ioctl(). > > > > Signed-off-by: Arnd Bergmann > > Besides the two minor things below > > Acked-by: Heiko Carstens Thanks a lot for the reviewed. Both issues are fixed now, and I'm pushing out new git branches after adding the other Acks I got so far. Arnd