From: Arnd Bergmann <arnd@arndb.de>
To: David Howells <dhowells@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <christian@brauner.io>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] uapi: Wire up the mount API syscalls on non-x86 arches
Date: Thu, 16 May 2019 13:32:13 +0200 [thread overview]
Message-ID: <CAK8P3a1mUoph0xwmxPfYAcRU=uhQj83VmgTfthVnQ0H1cQpHQQ@mail.gmail.com> (raw)
In-Reply-To: <155800584626.26930.8723624357941420192.stgit@warthog.procyon.org.uk>
On Thu, May 16, 2019 at 1:24 PM David Howells <dhowells@redhat.com> wrote:
>
> Wire up the mount API syscalls on non-x86 arches.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
but found a small mistake that breaks compilation on the
asm-generic architectures:
> diff --git a/arch/arm64/include/asm/unistd32.h b/arch/arm64/include/asm/unistd32.h
> index 23f1a44acada..3734789e9f25 100644
> --- a/arch/arm64/include/asm/unistd32.h
> +++ b/arch/arm64/include/asm/unistd32.h
> @@ -874,6 +874,18 @@ __SYSCALL(__NR_io_uring_setup, sys_io_uring_setup)
> __SYSCALL(__NR_io_uring_enter, sys_io_uring_enter)
> #define __NR_io_uring_register 427
> __SYSCALL(__NR_io_uring_register, sys_io_uring_register)
> +#define __NR_open_tree 428
> +__SYSCALL(__NR_open_tree, open_tree)
> +#define __NR_move_mount 429
> +__SYSCALL(__NR_move_mount, move_mount)
> +#define __NR_fsopen 430
> +__SYSCALL(__NR_fsopen, fsopen)
> +#define __NR_fsconfig 431
> +__SYSCALL(__NR_fsconfig, fsconfig)
> +#define __NR_fsmount 432
> +__SYSCALL(__NR_fsmount, fsmount)
> +#define __NR_fspick 433
> +__SYSCALL(__NR_fspick, fspick)
This needs a sys_ prefix for each of the entry point names
> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> index dee7292e1df6..29bf3bbcce78 100644
> --- a/include/uapi/asm-generic/unistd.h
> +++ b/include/uapi/asm-generic/unistd.h
> @@ -832,9 +832,21 @@ __SYSCALL(__NR_io_uring_setup, sys_io_uring_setup)
> __SYSCALL(__NR_io_uring_enter, sys_io_uring_enter)
> #define __NR_io_uring_register 427
> __SYSCALL(__NR_io_uring_register, sys_io_uring_register)
> +#define __NR_open_tree 428
> +__SYSCALL(__NR_open_tree, open_tree)
> +#define __NR_move_mount 429
> +__SYSCALL(__NR_move_mount, move_mount)
> +#define __NR_fsopen 430
> +__SYSCALL(__NR_fsopen, fsopen)
> +#define __NR_fsconfig 431
> +__SYSCALL(__NR_fsconfig, fsconfig)
> +#define __NR_fsmount 432
> +__SYSCALL(__NR_fsmount, fsmount)
> +#define __NR_fspick 433
> +__SYSCALL(__NR_fspick, fspick)
>
> #undef __NR_syscalls
> -#define __NR_syscalls 428
> +#define __NR_syscalls 434
Same here.
Arnd
prev parent reply other threads:[~2019-05-16 11:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 11:23 [PATCH 0/4] uapi, vfs: Change the mount API UAPI David Howells
2019-05-16 11:23 ` [PATCH 1/4] uapi, fs: make all new mount api fds cloexec by default David Howells
2019-05-16 11:23 ` [PATCH 2/4] uapi, fsopen: use square brackets around "fscontext" David Howells
2019-05-16 11:23 ` [PATCH 3/4] uapi, x86: Fix the syscall numbering of the mount API syscalls David Howells
2019-05-16 11:29 ` Arnd Bergmann
2019-05-16 11:24 ` [PATCH 4/4] uapi: Wire up the mount API syscalls on non-x86 arches David Howells
2019-05-16 11:32 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1mUoph0xwmxPfYAcRU=uhQj83VmgTfthVnQ0H1cQpHQQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).