From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0463BCA9EA1 for ; Fri, 18 Oct 2019 13:31:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5872222C2 for ; Fri, 18 Oct 2019 13:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408531AbfJRNbe (ORCPT ); Fri, 18 Oct 2019 09:31:34 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:45416 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408509AbfJRNbe (ORCPT ); Fri, 18 Oct 2019 09:31:34 -0400 Received: by mail-qk1-f194.google.com with SMTP id z67so5230288qkb.12; Fri, 18 Oct 2019 06:31:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tpuqPfUBPTEqWzHgbYNa7ad4BsKzW7eS2KnXx2Hiqco=; b=txP5fwCI3WUIZws4MVeGifPoLuCDRPA7Plw7TyNdkA53uP+G8MWtyuFOH+lfR22JFj +DroiMesz8CxtTpkRL1TAWOLARyE8GPTdVUuz4VBpaxHcrcDh8SsaP5rNqfgP3gm7+PN ECLoGVu53k9z9B41BZ7G2Fvj0FV7WIWC1JQEOUlKpxpz7LN7w/P/x4aumhm3oFXKXMrz y/kizVxtj4OOLWW7XnSkC4aRq9wCoSX/ADsRGlobqepGAglSjvtLxnjF1zOmbc9K9jIv OkOv9fmie4IjnvHRGizDncx3j1RD4EriOoE4zj41tho/ptxHB3XqvWyImDxmI3/gdHPL k8zQ== X-Gm-Message-State: APjAAAUC6wfDQkGolXKY+AfONn+/eXLzKpkD+4amJQt1tzKwYOpq3Nd1 JaV54ly69MkRPgWEKu6Y9s0c+pEdrVdr+1Oyi8o3zqo+ X-Google-Smtp-Source: APXvYqzOMqpWH53nssj4UOb90GoWE0aTwtTW8fdt3FuVvxqZJH/Yp7jjOPhd0gjMwu9H15wolHwF2BSyXBxNndzQuco= X-Received: by 2002:a37:9442:: with SMTP id w63mr8599892qkd.138.1571405492947; Fri, 18 Oct 2019 06:31:32 -0700 (PDT) MIME-Version: 1.0 References: <20191009190853.245077-1-arnd@arndb.de> <20191009191044.308087-32-arnd@arndb.de> <1984049ff0e359801401fbbcbdbc21ee0a64c1a9.camel@codethink.co.uk> In-Reply-To: <1984049ff0e359801401fbbcbdbc21ee0a64c1a9.camel@codethink.co.uk> From: Arnd Bergmann Date: Fri, 18 Oct 2019 15:31:16 +0200 Message-ID: Subject: Re: [Y2038] [PATCH v6 31/43] compat_ioctl: move WDIOC handling into wdt drivers To: Ben Hutchings Cc: Al Viro , y2038 Mailman List , Linux FS-devel Mailing List , Guenter Roeck , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Oct 18, 2019 at 2:49 PM Ben Hutchings wrote: > > On Wed, 2019-10-09 at 21:10 +0200, Arnd Bergmann wrote: > > All watchdog drivers implement the same set of ioctl commands, and > > fortunately all of them are compatible between 32-bit and 64-bit > > architectures. > > > > Modern drivers always go through drivers/watchdog/wdt.c as an abstraction > > layer, but older ones implement their own file_operations on a character > > device for this. > > > > Move the handling from fs/compat_ioctl.c into the individual drivers. > > > > Note that most of the legacy drivers will never be used on 64-bit > > hardware, because they are for an old 32-bit SoC implementation, but > > doing them all at once is safer than trying to guess which ones do > > or do not need the compat_ioctl handling. > > > > Reviewed-by: Guenter Roeck > > Signed-off-by: Arnd Bergmann > > --- > > arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 1 + > > arch/um/drivers/harddog_kern.c | 1 + > > drivers/char/ipmi/ipmi_watchdog.c | 1 + > > drivers/hwmon/fschmd.c | 1 + > > drivers/rtc/rtc-ds1374.c | 1 + > [...] > > It Looks like you missed a couple: > > drivers/rtc/rtc-m41t80.c No idea how I missed this. Adding it now. > drivers/watchdog/kempld_wdt.c This one is covered: the watchdog_ops->ioctl is called by the wdt_dev_ioctl() function as a fallback. After checking once more, I did find another instance I missed though: drivers/hwmon/w83793.c, I'm adding that as welll now. m41t80 does not seem to have any 64-bit machines using it, but w83793 does, and they clearly both should have been changed. Thanks for the review! Arnd