From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD59FC33CB1 for ; Wed, 15 Jan 2020 13:07:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91E852081E for ; Wed, 15 Jan 2020 13:07:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HgGdXFID" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726220AbgAONHj (ORCPT ); Wed, 15 Jan 2020 08:07:39 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:46051 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726071AbgAONHj (ORCPT ); Wed, 15 Jan 2020 08:07:39 -0500 Received: by mail-oi1-f195.google.com with SMTP id n16so15258817oie.12; Wed, 15 Jan 2020 05:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Uc0xbXgTVUa2g+0VE0qpo9jTGqpit0XhHI4GsKKT/VM=; b=HgGdXFIDSNlO1Wse+Ln8TzTGQlaJMQ4UTejLeKnr1VxiJ20xDmvuOWL3Go7oaPa/rc kBjg84j4tiOoZrmdF+zV8w4A3qHpFZV9jrwWjIfFjzm/8WkpHlbi3rHGmYrgsBwCIZzo S1fsUA1xKeZzAD1NecFw5GDYp/G+3ZVDriiqwSxnsuxmogmQ1+t8kv/KCjaywZkfkKbn oCvHJSc/D6rY76WJlE78yWIchkHM7EYK4QMBxA0+5eYsnuk2IAtzB97yTW9fBjwrg8fl lY9aB0QeyTcxLXPLEsF1MfAPuLzUJc4wQsTbYAu6aZPcNc7lyl7eCGvc/hEAf2v0xhdF 3faA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Uc0xbXgTVUa2g+0VE0qpo9jTGqpit0XhHI4GsKKT/VM=; b=AB7rUuckC/nKgpTO3reVllw02ZvXcC0fXCx5IBBDtUEnjzOAiMon3a4zgJ1lVewoyg aInj2Yly59+Nbp36nzAzCmfdFkWr3oYODg44z/T9E59AHbO/YorIHtSEpYi6zIkeQOy2 4B0Ld7DQtVKaW5tMbnoXXMlv7QUcqTCqODOmIrG8NHQ3B65bedphizqOTHIfonh/rIT1 R0tL4gZe01/wHQnEvx3ExlzuEIpBu24hJHEMP+piMDyWMRq9C3VvAWkj5lASHlGclRU+ 1YigiPLJtE/mT7WMwoaQprrsYPcJGNJuwfEvVgRP20XIkUWSTH0rKZplXgKUuSQ+EE7q wwkA== X-Gm-Message-State: APjAAAXl6T+xomXb3jF8DBHVId7ufgDmYREINs4YUAVKLYJuIBxez8kr j2rstWD+Zj6hyuLE7XOF9sXRVdOhCWO10onthLo= X-Google-Smtp-Source: APXvYqy8KPZfk8cDJsJNQSMol4iJR++qWDEKUw7L7ZKirqnVJrVVuMfxN+xO5EiWgDtNwQC/oS05WZZpoq7mkjTzN6g= X-Received: by 2002:aca:5490:: with SMTP id i138mr21103528oib.69.1579093658646; Wed, 15 Jan 2020 05:07:38 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a8a:87:0:0:0:0:0 with HTTP; Wed, 15 Jan 2020 05:07:38 -0800 (PST) In-Reply-To: References: <20200115082447.19520-1-namjae.jeon@samsung.com> <20200115082447.19520-6-namjae.jeon@samsung.com> From: Namjae Jeon Date: Wed, 15 Jan 2020 22:07:38 +0900 Message-ID: Subject: Re: [PATCH v10 05/14] exfat: add file operations To: Arnd Bergmann Cc: Namjae Jeon , "linux-kernel@vger.kernel.org" , Linux FS-devel Mailing List , gregkh , Valdis Kletnieks , Christoph Hellwig , sj1557.seo@samsung.com, =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org 2020-01-15 18:56 GMT+09:00, Arnd Bergmann : > On Wed, Jan 15, 2020 at 9:28 AM Namjae Jeon > wrote: > >> + >> + ktime_get_real_ts64(&ts); >> + exfat_set_entry_time(sbi, &ts, >> + &ep->dentry.file.modify_time, >> + &ep->dentry.file.modify_date, >> + &ep->dentry.file.modify_tz); > > I think this part should use current_time() instead of > ktime_get_real_ts64() > so it gets truncated to the correct resolution and range. > > Please also check if there are other callers of ktime_get_real_ts64() that > may need the same change. Okay, I will change them. Thanks! > > Arnd >