From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1612C43331 for ; Fri, 27 Mar 2020 17:26:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7112F2073B for ; Fri, 27 Mar 2020 17:26:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hmBCjbTg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727652AbgC0R0r (ORCPT ); Fri, 27 Mar 2020 13:26:47 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:45684 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbgC0R0r (ORCPT ); Fri, 27 Mar 2020 13:26:47 -0400 Received: by mail-pg1-f196.google.com with SMTP id o26so4872219pgc.12 for ; Fri, 27 Mar 2020 10:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X8ps1N/pYBA7KlC6SJyDXK1HkCeJUluIuEnwRO89GEU=; b=hmBCjbTgMqFJZImRqjN4cWi+1oiD8+HAEmEByq7V4Xj+pZ40AbphunjFgtdfMF2Y5E aiAZ5kx5UWMqooP0//e5S8mGaI8Ns8HwOdDgx7LqV3ixxxKvsuEm2O643LkB5cvQwDNs DdPViDg7+o6QLCWbOcgeV5do6umR9em7CJt/8/ncZqGRxQ4GfFy4VTfIRpnRiN0WL3MI 1LKO95FrPge2Dn8K07Pn/PuHLqlM1eb7ATRyMzvf6cj6cqpbFw8fcGumYtlQRXfSx33h G3sfCxaRgBHOnZjHw7bj37vBur+WP4wkmVKnUdPEnQ1j9TvHSPLXH+WUDWzuUQp5s5SP JniA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X8ps1N/pYBA7KlC6SJyDXK1HkCeJUluIuEnwRO89GEU=; b=Y3kULJpVBnAh1SE/J1Kz+sTCUYSPZMBOImMpmSTtCR7Kjm+m7/33sJLJCvcwLhHZmc 9wC3oZZlTRWicYyz53Nch4LsgCnVYk3YqfApq+0fCnfy0AATqK7VW28obKN3xX95h8BC u7pgZVCR7+ZOn89f14hA+kht0CYvpAr8wWaFbcG/8gkl9dRv04uSqEHdgORxpgUZgakw rM6Yny1ilqef3JCbCFjamsUQb1vatrg0k4yUg8J6s+29BNrc6drV9HAjQWbAF/X6xB3p AVCA7pyEi8dSUgUR2xuadds4o+nu1sR9cvjpbG2tZ0keeOfzTn+IBEb0zlWGFgU2KZMW cbFQ== X-Gm-Message-State: ANhLgQ2GKSDe5kHk2AEF+TszIItFgPMVtHs9HeKSKNPRkDS/yHldt28r hNhTtLSBLxdFgp3LGFLb8Nk8KDPRN1s2MXJPPIT7AeZn X-Google-Smtp-Source: ADFU+vskNw4rx9J8k/JB6zNGDuE+XATYo7xfLE+NCQ/VTYSZNrt8mav9Wo2CNYj9Y/bYulHHAACI97tU0sg7i+3mX0I= X-Received: by 2002:a63:4e22:: with SMTP id c34mr335809pgb.263.1585330005540; Fri, 27 Mar 2020 10:26:45 -0700 (PDT) MIME-Version: 1.0 References: <20200327171030.30625-1-natechancellor@gmail.com> In-Reply-To: <20200327171030.30625-1-natechancellor@gmail.com> From: Nick Desaulniers Date: Fri, 27 Mar 2020 10:26:34 -0700 Message-ID: Subject: Re: [PATCH -next] fanotify: Fix the checks in fanotify_fsid_equal To: Nathan Chancellor Cc: Jan Kara , Amir Goldstein , linux-fsdevel , LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Mar 27, 2020 at 10:10 AM Nathan Chancellor wrote: > > Clang warns: > > fs/notify/fanotify/fanotify.c:28:23: warning: self-comparison always > evaluates to true [-Wtautological-compare] > return fsid1->val[0] == fsid1->val[0] && fsid2->val[1] == fsid2->val[1]; > ^ > fs/notify/fanotify/fanotify.c:28:57: warning: self-comparison always > evaluates to true [-Wtautological-compare] > return fsid1->val[0] == fsid1->val[0] && fsid2->val[1] == fsid2->val[1]; > ^ > 2 warnings generated. > > The intention was clearly to compare val[0] and val[1] in the two > different fsid structs. Fix it otherwise this function always returns > true. > > Fixes: afc894c784c8 ("fanotify: Store fanotify handles differently") > Link: https://github.com/ClangBuiltLinux/linux/issues/952 > Signed-off-by: Nathan Chancellor Thanks for the patch. Subtle bugs that are off by one character have always been hard for me to spot! Reviewed-by: Nick Desaulniers > --- > fs/notify/fanotify/fanotify.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c > index 7a889da1ee12..cb54ecdb3fb9 100644 > --- a/fs/notify/fanotify/fanotify.c > +++ b/fs/notify/fanotify/fanotify.c > @@ -25,7 +25,7 @@ static bool fanotify_path_equal(struct path *p1, struct path *p2) > static inline bool fanotify_fsid_equal(__kernel_fsid_t *fsid1, > __kernel_fsid_t *fsid2) > { > - return fsid1->val[0] == fsid1->val[0] && fsid2->val[1] == fsid2->val[1]; > + return fsid1->val[0] == fsid2->val[0] && fsid1->val[1] == fsid2->val[1]; > } > > static bool fanotify_fh_equal(struct fanotify_fh *fh1, > -- -- Thanks, ~Nick Desaulniers