From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471B1C35254 for ; Mon, 10 Feb 2020 18:31:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D07420838 for ; Mon, 10 Feb 2020 18:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581359463; bh=omPLg79kMPvUSKiyNNvd0/ylILD31wzwomGJPrNGyQg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ZICT7VC0cWdWqmWIWkEoO0MMCPr4/ymixfpMLNRp73tcUZDZ2NZfjjfpdoawJmdKU n3Q3DWBwqjqKug0B/DAXyBFpVpfBrxuhVYKHm6qsHfNSu/sBJWz/EeXUieMAtLIkDe Z8c4q5lZ2IrKL9nL1gKCyY6hqbka4PpVFV+b+qjw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727600AbgBJSa7 (ORCPT ); Mon, 10 Feb 2020 13:30:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:50486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727496AbgBJSa6 (ORCPT ); Mon, 10 Feb 2020 13:30:58 -0500 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2EA7920870 for ; Mon, 10 Feb 2020 18:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581359458; bh=omPLg79kMPvUSKiyNNvd0/ylILD31wzwomGJPrNGyQg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dZmJEdXyo7TiCuP494908+DDQqiXuByAFM/5ZYZdUBh1RBbsjG4Nj8BtvNderACDu buUtqSZaMUtzDuCNulwdaDkgV5kqZL7lno4QgAbQ/lGQBv705tgeTFjmzJtXJCSjQ1 BFRJCZcEs4eVwRoiOiwkJ6JclPVFDKSbcrF3PIR0= Received: by mail-wr1-f44.google.com with SMTP id k11so9020251wrd.9 for ; Mon, 10 Feb 2020 10:30:58 -0800 (PST) X-Gm-Message-State: APjAAAWcHROSf0h5CiREAiUQok5geLwDvLLn45grUJqAzatvDYl9h3B+ y9JDkpqtqH+bP6TeEXvEiEJ9gUGYKiivqinrNW7nYQ== X-Google-Smtp-Source: APXvYqzr7b50VDslir7PKIqAsDCapDo139eIqmv/8TM15nWdMYYpgSAHPnXtkGdcaP89mSWD9lXJHS+xhiOGpQ18who= X-Received: by 2002:adf:ea85:: with SMTP id s5mr3242839wrm.75.1581359456683; Mon, 10 Feb 2020 10:30:56 -0800 (PST) MIME-Version: 1.0 References: <20200210150519.538333-1-gladkov.alexey@gmail.com> <20200210150519.538333-6-gladkov.alexey@gmail.com> In-Reply-To: <20200210150519.538333-6-gladkov.alexey@gmail.com> From: Andy Lutomirski Date: Mon, 10 Feb 2020 10:30:45 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 05/11] proc: add helpers to set and get proc hidepid and gid mount options To: Alexey Gladkov Cc: LKML , Kernel Hardening , Linux API , Linux FS Devel , Linux Security Module , Akinobu Mita , Alexander Viro , Alexey Dobriyan , Andrew Morton , Andy Lutomirski , Daniel Micay , Djalal Harouni , "Dmitry V . Levin" , "Eric W . Biederman" , Greg Kroah-Hartman , Ingo Molnar , "J . Bruce Fields" , Jeff Layton , Jonathan Corbet , Kees Cook , Linus Torvalds , Oleg Nesterov , Solar Designer Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Feb 10, 2020 at 7:06 AM Alexey Gladkov wrote: > > This is a cleaning patch to add helpers to set and get proc mount > options instead of directly using them. This make it easy to track > what's happening and easy to update in future. On a cursory inspection, this looks like it obfuscates the code, and I don't see where it does something useful later in the series. What is this abstraction for? --Andy