From: Shakeel Butt <shakeelb@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Jan Kara <jack@suse.com>, Greg Thelen <gthelen@google.com>,
Amir Goldstein <amir73il@gmail.com>, Roman Gushchin <guro@fb.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 1/2] fs: fsnotify: account fsnotify metadata to kmemcg
Date: Tue, 26 Jun 2018 13:05:55 -0700 [thread overview]
Message-ID: <CALvZod5VU0_==ggX82P19v=X7zpKj1xO5qPZ1mep4yRVhr7qaw@mail.gmail.com> (raw)
In-Reply-To: <20180626190619.GB3958@cmpxchg.org>
On Tue, Jun 26, 2018 at 12:03 PM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> On Mon, Jun 25, 2018 at 04:06:58PM -0700, Shakeel Butt wrote:
> > @@ -140,8 +141,9 @@ struct fanotify_event_info *fanotify_alloc_event(struct fsnotify_group *group,
> > struct inode *inode, u32 mask,
> > const struct path *path)
> > {
> > - struct fanotify_event_info *event;
> > + struct fanotify_event_info *event = NULL;
> > gfp_t gfp = GFP_KERNEL;
> > + struct mem_cgroup *old_memcg = NULL;
> >
> > /*
> > * For queues with unlimited length lost events are not expected and
> > @@ -151,19 +153,25 @@ struct fanotify_event_info *fanotify_alloc_event(struct fsnotify_group *group,
> > if (group->max_events == UINT_MAX)
> > gfp |= __GFP_NOFAIL;
> >
> > + /* Whoever is interested in the event, pays for the allocation. */
> > + if (group->memcg) {
> > + gfp |= __GFP_ACCOUNT;
> > + old_memcg = memalloc_use_memcg(group->memcg);
> > + }
>
> group->memcg is only NULL when memcg is disabled or there is some
> offlining race. Can you make memalloc_use_memcg(NULL) mean that it
> should charge root_mem_cgroup instead of current->mm->memcg? That way
> we can make this site unconditional while retaining the behavior:
>
> gfp_t gfp = GFP_KERNEL | __GFP_ACCOUNT;
>
> memalloc_use_memcg(group->memcg);
> kmem_cache_alloc(..., gfp);
> out:
> memalloc_unuse_memcg();
>
> (dropping old_memcg and the unuse parameter as per the other mail)
>
group->memcg is only NULL when memcg is disabled (i.e.
get_mem_cgroup_from_mm() returns root_mem_cgroup for offlined
mm->memcg). Though group->memcg can point to an offlined memcg.
If I understand you correctly this is what we want:
1. If group->memcg is NULL then __GFP_ACCOUNT is a noop i.e. memcg is disabled.
2. If group->memcg is root_mem_cgroup, then __GFP_ACCOUNT again is a
kind of noop (charges to root_mem_cgroups are bypassed).
3. If group->memcg is offlined memcg, then make __GFP_ACCOUNT noop by
returning root_mem_cgroup from get_mem_cgroup_from_current().
4. Else charge group->memcg.
This seems reasonable. After your Ack and Amir's or Jan's answer to
the nesting query, I will resend the next version of this patch
series.
In future if we find any use-cases of memalloc_use_memcg nesting then
we can make it work for nesting.
thanks,
Shakeel
next prev parent reply other threads:[~2018-06-26 20:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 23:06 [PATCH v7 0/2] Directed kmem charging Shakeel Butt
2018-06-25 23:06 ` [PATCH 1/2] fs: fsnotify: account fsnotify metadata to kmemcg Shakeel Butt
2018-06-26 5:49 ` Amir Goldstein
2018-06-26 18:00 ` Shakeel Butt
2018-06-26 18:57 ` Johannes Weiner
2018-06-26 19:07 ` Shakeel Butt
2018-06-27 7:31 ` Jan Kara
2018-06-26 19:06 ` Johannes Weiner
2018-06-26 20:05 ` Shakeel Butt [this message]
2018-06-27 5:50 ` Amir Goldstein
2018-06-25 23:06 ` [PATCH 2/2] fs, mm: account buffer_head " Shakeel Butt
2018-06-27 19:12 [PATCH v8 0/2] Directed kmem charging Shakeel Butt
2018-06-27 19:12 ` [PATCH 1/2] fs: fsnotify: account fsnotify metadata to kmemcg Shakeel Butt
2018-06-28 10:02 ` Jan Kara
2018-06-28 19:21 ` Shakeel Butt
2018-06-29 9:52 ` Michal Hocko
2018-06-29 17:44 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALvZod5VU0_==ggX82P19v=X7zpKj1xO5qPZ1mep4yRVhr7qaw@mail.gmail.com' \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).