From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2305C433DB for ; Mon, 8 Mar 2021 06:14:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73E4E6514D for ; Mon, 8 Mar 2021 06:14:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234805AbhCHGNl (ORCPT ); Mon, 8 Mar 2021 01:13:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234811AbhCHGNU (ORCPT ); Mon, 8 Mar 2021 01:13:20 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CC28C06175F for ; Sun, 7 Mar 2021 22:13:19 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id x4so12467970lfu.7 for ; Sun, 07 Mar 2021 22:13:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5zuLyIMtTu9vDSB4XkfAbZ0uX4PD6RfhA/3r6OaoQnI=; b=r6Qi4/4arJHvPgvhwoboibouvpk0NWSX8MipZS8QZ+BrdZdxwLBJKUDwMfgmWSW8Yu OZH2B04mSUrDBog35HKb+a26mrY/JSo/rqgSYqxxjkElj0TqI93KxvK8mDOdBk4yZ7J4 X/0C1ExrYOpYy5hiIVH9AbKIOyHIhFTpjKjr+hIOCJRuZ+ncLhH7CbLiEcOvouFEaks8 ShgECUbJ2CftJDm7mTfytGlC3iYLnz1LyTBoe8LmYjmUAUctAzwe0brhEZqv408a/h58 shgs2HrLbuotvQ96Mkx66y73Bhm7sRyhj8qZJ3j4bk8muAJ9YVm+P3RmqRFS57fU58zb pGIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5zuLyIMtTu9vDSB4XkfAbZ0uX4PD6RfhA/3r6OaoQnI=; b=INmN1nYHelV8k5l6XVI6BVYpyL04FN9+EqavQgNgUrPdLvcATK8gLxs0XUNngy1Dcm AM45B0AAfklTAMSilIbH2EaURxRH/zxXzotIIGVMJH9iND9wD9wBxC+GfZL++q7tofkw bOPo+AkKyKTZcRdm0e23kE019a+cBo5K74opdrS+xLsdsJg247PiBIZbT0UOx3BbObQ6 9+HAIp/Z+UXns58yIHRXW2oIdCRrTYByM0r2OUMN89AHUjXjTFPySivQY+tDtrzjxx7k R0YBbECpwHeyeXtXrGWI5/uDKbtJTy/IovcaThlBxtGSjS3vtF1U1BiVHJn8XpBlyl0F gTUQ== X-Gm-Message-State: AOAM533m7qT3+7FpoDV9yy/69u6HWjSMYLyQZqS96z8jPC4GpWbsqUjX NEFBPyLdg1JcfNGiU8FCeXbFi8YjyiAgxhah23jW+A== X-Google-Smtp-Source: ABdhPJxc0v63Dy8DvVAk/DYaLK47IbF3fY9fLvX7nIB1BSkKIxNiS3PvWjGKhbB+E2Joya7ljUn0FqeLRBf/8nKdAng= X-Received: by 2002:a05:6512:6c6:: with SMTP id u6mr13260075lff.347.1615183998124; Sun, 07 Mar 2021 22:13:18 -0800 (PST) MIME-Version: 1.0 References: <20210217001322.2226796-1-shy828301@gmail.com> <20210217001322.2226796-6-shy828301@gmail.com> In-Reply-To: <20210217001322.2226796-6-shy828301@gmail.com> From: Shakeel Butt Date: Sun, 7 Mar 2021 22:13:04 -0800 Message-ID: Subject: Re: [v8 PATCH 05/13] mm: vmscan: use kvfree_rcu instead of call_rcu To: Yang Shi , paulmck@kernel.org Cc: Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Feb 16, 2021 at 4:13 PM Yang Shi wrote: > > Using kvfree_rcu() to free the old shrinker_maps instead of call_rcu(). > We don't have to define a dedicated callback for call_rcu() anymore. > > Signed-off-by: Yang Shi > --- > mm/vmscan.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 2e753c2516fa..c2a309acd86b 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -192,11 +192,6 @@ static inline int shrinker_map_size(int nr_items) > return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long)); > } > > -static void free_shrinker_map_rcu(struct rcu_head *head) > -{ > - kvfree(container_of(head, struct memcg_shrinker_map, rcu)); > -} > - > static int expand_one_shrinker_map(struct mem_cgroup *memcg, > int size, int old_size) > { > @@ -219,7 +214,7 @@ static int expand_one_shrinker_map(struct mem_cgroup *memcg, > memset((void *)new->map + old_size, 0, size - old_size); > > rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_map, new); > - call_rcu(&old->rcu, free_shrinker_map_rcu); > + kvfree_rcu(old); Please use kvfree_rcu(old, rcu) instead of kvfree_rcu(old). The single param can call synchronize_rcu().