From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76666C433E6 for ; Mon, 8 Mar 2021 17:49:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41071652AF for ; Mon, 8 Mar 2021 17:49:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230429AbhCHRss (ORCPT ); Mon, 8 Mar 2021 12:48:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230525AbhCHRsj (ORCPT ); Mon, 8 Mar 2021 12:48:39 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D854FC06174A for ; Mon, 8 Mar 2021 09:48:38 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id v2so9370236lft.9 for ; Mon, 08 Mar 2021 09:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=giD8jSsyZJtO1DBnfL0AaLcvwbpWQ52I68uSxFCyz/k=; b=QPpLMFgSpH9WgV4NcTrB7d+hZtjE/5GT3F2G644kSvUU9b3EGps3rmRAaXpJdfSNrw nBbGd4eLyVIbdTkY7G9viNOngWpUPb8hF3N6jNc8xSGecRsOjJJ18VOIDrclO79YnIej M+KgZzdCA1b5KoWhpxEZz0iXTRSimI/UDdN7cNiISFBjW9ksoNl6GN+FvNbU8wYWq6zk h7K3H4Ih+dZSluL+jMFMYRNXk+3Nv02Ztvu/bvSes259hNSUnyW9tNlloRckDhyGcL26 +f9oprjrH1qwP+ILRdp54S1RPGcKQvitB+ByslpCOaMXBdB3UJXh/MvLiCoFJH04MSVA Y7Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=giD8jSsyZJtO1DBnfL0AaLcvwbpWQ52I68uSxFCyz/k=; b=RsetQskIVzwT80UbVVEVa1r1tLv6DB6Ekhb3Sh/+ZKYui6apwwiiNMgJMBS5qVkBT3 yKLY+3DGXMs0uioTu47ZOaG3xBDV2OVZAyP26bNPbcBD4ipwBXV9azn9Cpa0yzfG0azh 5Z/eQHTIsghKT0CsC6n3efiaWCkuLNLScA8ZlzIgfXLXwzfPTVi6I2ff8ukZ1RPdFVFJ E1UDR8mEi8OfnRbJ9XZykxOYv5WnTRd7HuGXbodbKDtgrP7ug6KUYac5x7WYcsbqagzy 94DMZQR/N3ZpHJcfABA7xw85NJVWXafg1c7rKUrUsXWGlf5IujkjE2JodyVHdEXPmoVI PdKw== X-Gm-Message-State: AOAM532tazah6HbMZp/gomZpy3BDdNeFbeLDIZy0hJcCk6EX0vk+rUbI Edm44t+RIWaWk2T+8ldGWmrrDe0UH90SPYSOPvIlXg== X-Google-Smtp-Source: ABdhPJw7Hi0i7dAd1dfvZWz3HJ1oxl9iDjYmhMQmd2hfeQvGJcpHO+DIsojeXKaCQlDDTS3CbgYU6Vn1r2LSkTkJuX0= X-Received: by 2002:a05:6512:6c6:: with SMTP id u6mr14739762lff.347.1615225717126; Mon, 08 Mar 2021 09:48:37 -0800 (PST) MIME-Version: 1.0 References: <20210217001322.2226796-1-shy828301@gmail.com> <20210217001322.2226796-9-shy828301@gmail.com> In-Reply-To: <20210217001322.2226796-9-shy828301@gmail.com> From: Shakeel Butt Date: Mon, 8 Mar 2021 09:48:22 -0800 Message-ID: Subject: Re: [v8 PATCH 08/13] mm: vmscan: use a new flag to indicate shrinker is registered To: Yang Shi Cc: Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Feb 16, 2021 at 4:13 PM Yang Shi wrote: > > Currently registered shrinker is indicated by non-NULL shrinker->nr_deferred. > This approach is fine with nr_deferred at the shrinker level, but the following > patches will move MEMCG_AWARE shrinkers' nr_deferred to memcg level, so their > shrinker->nr_deferred would always be NULL. This would prevent the shrinkers > from unregistering correctly. > > Remove SHRINKER_REGISTERING since we could check if shrinker is registered > successfully by the new flag. > > Acked-by: Kirill Tkhai > Acked-by: Vlastimil Babka > Signed-off-by: Yang Shi Reviewed-by: Shakeel Butt