archive mirror
 help / color / mirror / Atom feed
  • * Re: general protection fault in sockfs_setattr
           [not found]   ` <>
           [not found]     ` <>
    @ 2018-06-06 18:21     ` Cong Wang
      1 sibling, 0 replies; 2+ messages in thread
    From: Cong Wang @ 2018-06-06 18:21 UTC (permalink / raw)
      To: shankarapailoor, linux-fsdevel
      Cc: David Miller, LKML, syzkaller, Linux Kernel Network Developers
    On Tue, Jun 5, 2018 at 7:19 PM, shankarapailoor
    <> wrote:
    > Hi Cong,
    > I added that check and it seems to stop the crash. Like you said, I
    > don't see where the reference count for the file is increased. The
    > inode lock also seems to be held during this call.
    I know inode lock is held for ->setattr(), but not for ->release(), this
    is why I suspect sock_close() could still race with sockfs_setattr()
    after my patch.
    I am not sure if it is crazy to just hold fd refcnt for fchmodat() too..
    ^ permalink raw reply	[flat|nested] 2+ messages in thread

  • end of thread, other threads:[~2018-06-06 18:21 UTC | newest]
    Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
    -- links below jump to the message on this page --
         [not found] <>
         [not found] ` <>
         [not found]   ` <>
         [not found]     ` <>
    2018-06-06 13:30       ` general protection fault in sockfs_setattr shankarapailoor
    2018-06-06 18:21     ` Cong Wang

    This is a public inbox, see mirroring instructions
    for how to clone and mirror all data and code used for this inbox;
    as well as URLs for NNTP newsgroup(s).