From: Ard Biesheuvel <ardb@kernel.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-dev@igalia.com, kernel@gpiccoli.net, anton@enomsg.org,
ccross@android.com, tony.luck@intel.com,
linux-efi@vger.kernel.org
Subject: Re: [PATCH 8/8] efi: pstore: Add module parameter for setting the record size
Date: Fri, 7 Oct 2022 17:06:44 +0200 [thread overview]
Message-ID: <CAMj1kXE6aObn7hGneGMMiJ-ss7YaiYDFL+HqktYt2WMUpZnFjQ@mail.gmail.com> (raw)
In-Reply-To: <2a341c4d-763e-cfa4-0537-93451d8614fa@igalia.com>
On Fri, 7 Oct 2022 at 15:46, Guilherme G. Piccoli <gpiccoli@igalia.com> wrote:
>
> On 07/10/2022 10:19, Ard Biesheuvel wrote:
> > [...]
> >
> > OVMF has
> >
> > OvmfPkg/OvmfPkgX64.dsc:
> > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> > OvmfPkg/OvmfPkgX64.dsc:
> > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x8400
> >
> > where the first one is without secure boot and the second with secure boot.
> >
> > Interestingly, the default is
> >
> > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x400
> >
> > so this is probably where this 1k number comes from. So perhaps it is
> > better to leave it at 1k after all :-(
> >
>
> Oh darn...
>
> So, let's stick with 1024 then? If so, no need for re-submitting right?
Well, I did spot this oddity
efi_pstore_info.buf = kmalloc(4096, GFP_KERNEL);
if (!efi_pstore_info.buf)
return -ENOMEM;
efi_pstore_info.bufsize = 1024;
So that hardcoded 4096 looks odd, but at least it is larger than the
default 1024. So what happens if you increase the record size to >
4096?
next prev parent reply other threads:[~2022-10-07 15:07 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 22:42 [PATCH 0/8] Some pstore improvements Guilherme G. Piccoli
2022-10-06 22:42 ` [PATCH 1/8] pstore: Improve error reporting in case of backend overlap Guilherme G. Piccoli
2022-10-06 23:27 ` Kees Cook
2022-10-06 23:35 ` Guilherme G. Piccoli
2022-10-06 22:42 ` [PATCH 2/8] pstore: Expose kmsg_bytes as a module parameter Guilherme G. Piccoli
2022-10-06 23:32 ` Kees Cook
2022-10-12 15:33 ` Guilherme G. Piccoli
2022-10-12 17:58 ` Kees Cook
2022-11-01 19:08 ` Guilherme G. Piccoli
2022-10-06 22:42 ` [PATCH 3/8] pstore: Inform unregistered backend names as well Guilherme G. Piccoli
2022-10-06 22:42 ` [PATCH 4/8] pstore: Alert on backend write error Guilherme G. Piccoli
2022-10-06 23:27 ` Kees Cook
2022-10-06 23:34 ` Guilherme G. Piccoli
2022-10-06 23:44 ` Kees Cook
2022-10-06 22:42 ` [PATCH 5/8] pstore: Fix long-term implicit conversions in the compression routines Guilherme G. Piccoli
2022-10-06 23:36 ` Kees Cook
2022-10-07 8:47 ` Ard Biesheuvel
2022-10-07 19:37 ` Kees Cook
2022-10-08 14:14 ` Guilherme G. Piccoli
2022-10-08 15:53 ` Ard Biesheuvel
2022-10-08 16:03 ` Guilherme G. Piccoli
2022-10-08 17:52 ` Ard Biesheuvel
2022-10-08 18:12 ` Guilherme G. Piccoli
2022-10-08 19:44 ` Kees Cook
2022-10-10 7:24 ` Ard Biesheuvel
2022-10-06 22:42 ` [PATCH 6/8] MAINTAINERS: Add a mailing-list for the pstore infrastructure Guilherme G. Piccoli
2022-10-06 23:22 ` Kees Cook
2022-10-06 23:29 ` Luck, Tony
2022-10-06 23:37 ` Kees Cook
2022-10-07 16:19 ` Luck, Tony
2022-10-07 16:21 ` Colin Cross
2022-10-07 16:32 ` Guilherme G. Piccoli
2022-10-07 19:25 ` Kees Cook
2022-10-06 22:42 ` [PATCH 7/8] efi: pstore: Follow convention for the efi-pstore backend name Guilherme G. Piccoli
2022-10-06 23:16 ` Kees Cook
2022-10-07 8:47 ` Ard Biesheuvel
2022-10-14 17:41 ` (subset) " Kees Cook
2022-10-06 22:42 ` [PATCH 8/8] efi: pstore: Add module parameter for setting the record size Guilherme G. Piccoli
2022-10-06 23:16 ` Kees Cook
2022-10-07 9:11 ` Ard Biesheuvel
2022-10-07 13:00 ` Guilherme G. Piccoli
2022-10-07 13:19 ` Ard Biesheuvel
2022-10-07 13:45 ` Guilherme G. Piccoli
2022-10-07 15:06 ` Ard Biesheuvel [this message]
2022-10-07 17:01 ` Guilherme G. Piccoli
2022-10-07 19:32 ` Kees Cook
2022-10-07 23:29 ` Guilherme G. Piccoli
2022-10-08 2:36 ` Kees Cook
2022-10-06 23:24 ` [PATCH 0/8] Some pstore improvements Kees Cook
2022-10-12 15:50 ` Guilherme G. Piccoli
2022-10-12 17:59 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXE6aObn7hGneGMMiJ-ss7YaiYDFL+HqktYt2WMUpZnFjQ@mail.gmail.com \
--to=ardb@kernel.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).