From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f195.google.com ([209.85.223.195]:33069 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbcGTGya (ORCPT ); Wed, 20 Jul 2016 02:54:30 -0400 MIME-Version: 1.0 In-Reply-To: References: <1468812716-30537-1-git-send-email-nicolas.pitre@linaro.org> <1468812716-30537-2-git-send-email-nicolas.pitre@linaro.org> From: Geert Uytterhoeven Date: Wed, 20 Jul 2016 08:54:28 +0200 Message-ID: Subject: Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups To: Nicolas Pitre Cc: Greg Ungerer , Linux FS Devel , "linux-kernel@vger.kernel.org" , Alexander Viro , David Howells Content-Type: text/plain; charset=UTF-8 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Nicolas, On Wed, Jul 20, 2016 at 6:09 AM, Nicolas Pitre wrote: > On Tue, 19 Jul 2016, Geert Uytterhoeven wrote: > >> On Tue, Jul 19, 2016 at 6:52 AM, Greg Ungerer wrote: >> > Seeing as you have modified quite a few printk calls is it worth >> > while annotating them with appropriate KERN_ERR, KERN_INFO, etc? >> >> You mean pr_err(), pr_info(), ... ;-) > > Done. Included in v3. Really? The only change in v3 is the Reviewed-by? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds