From: Andrei Vagin <avagin@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Sasha Levin <sashal@kernel.org>, stable <stable@vger.kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH AUTOSEL 5.5 542/542] pipe: use exclusive waits when reading or writing
Date: Thu, 5 Mar 2020 11:54:01 -0800 [thread overview]
Message-ID: <CANaxB-y6_OF4GMKUC=GssEY7Q-sH8y23F3wP2XT31=izSUvHSw@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wgpHbbOhYtxC1rrZ4xjm1GSfZk6_roKU4++3TQVFDMXiw@mail.gmail.com>
On Thu, Mar 5, 2020 at 10:41 AM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Thu, Mar 5, 2020 at 12:20 PM Andrei Vagin <avagin@gmail.com> wrote:
> >
> > After this change, one more criu test became flaky. This is due to one
> > of corner cases, so I am not sure that we need to fix something in the
> > kernel. I have fixed this issue in the test. I am not sure that this
> > will affect any real applications.
>
> It's an interesting test-case, but it's really not doing anything you
> should rely on.
I'm agree with this.
> But if CRIU itself depends on this behavior (rather than just a test),
> then I guess we need to.
>
> So is it just a test-case, or does CRIU itself depend on that "reads
> get full buffers"? As mentioned, that really _is_ fundamentally broken
> if there is any chance of signals..
No, it doesn't. I'm agree that we can wait an report from a real app.
Thanks!
Andrei
next prev parent reply other threads:[~2020-03-05 19:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200214154854.6746-1-sashal@kernel.org>
2020-02-14 15:48 ` [PATCH AUTOSEL 5.5 539/542] fuse: don't overflow LLONG_MAX with end offset Sasha Levin
2020-02-14 15:48 ` [PATCH AUTOSEL 5.5 542/542] pipe: use exclusive waits when reading or writing Sasha Levin
2020-02-18 9:51 ` Andrei Vagin
2020-02-18 17:36 ` Linus Torvalds
2020-02-18 17:54 ` Linus Torvalds
2020-02-18 18:17 ` Linus Torvalds
2020-02-18 18:20 ` Matthew Wilcox
2020-02-18 18:28 ` Linus Torvalds
2020-02-18 22:33 ` Andrei Vagin
2020-02-18 23:03 ` Linus Torvalds
2020-03-05 18:19 ` Andrei Vagin
2020-03-05 18:40 ` Linus Torvalds
2020-03-05 19:54 ` Andrei Vagin [this message]
2020-02-18 18:53 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANaxB-y6_OF4GMKUC=GssEY7Q-sH8y23F3wP2XT31=izSUvHSw@mail.gmail.com' \
--to=avagin@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).