From: Eiichi Tsukata <devel@etsukata.com>
To: hch@infradead.org
Cc: andi@firstfloor.org, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
linux-unionfs@vger.kernel.org
Subject: Re: [PATCH v1 3/4] f2fs: fix race between llseek SEEK_END and write
Date: Thu, 22 Nov 2018 14:42:41 +0900 [thread overview]
Message-ID: <CANhTXPTk0BB7DTSx1uMMRGiBJD+x3qkde_Q6AmqiiY_t3dYTGg@mail.gmail.com> (raw)
In-Reply-To: <20181121092314.GB10667@infradead.org>
2018年11月21日(水) 18:23 Christoph Hellwig <hch@infradead.org>:
>
> On Wed, Nov 21, 2018 at 11:43:59AM +0900, Eiichi Tsukata wrote:
> > This patch itself seems to be just a cleanup but with the
> > commit b25bd1d9fd87 ("vfs: fix race between llseek SEEK_END and write")
> > it fixes race.
>
> Please move this patch to the beginning of the series and replace
> the commit log with something like the one below. Note that your
> commit id is different from the one that will appear once applied
> upstream, so the aboe isn't too helpful.
>
> ---
> f2fs: use generic_file_llseek
>
> f2fs always passes inode->i_sb->s_maxbytes to generic_file_llseek_size,
> and thus should simply use generic_file_llseek. For now this is a just
> a cleanup, but it will allow f2fs to pick up a race fix in
> generic_file_llseek for free.
Thanks, I'll fix it in v2.
next prev parent reply other threads:[~2018-11-22 16:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 2:43 [PATCH v1 0/4] fs: fix race between llseek SEEK_END and write Eiichi Tsukata
2018-11-21 2:43 ` [PATCH v1 1/4] vfs: " Eiichi Tsukata
2018-11-21 2:43 ` [PATCH v1 2/4] ext4: " Eiichi Tsukata
2018-11-21 2:43 ` [PATCH v1 3/4] f2fs: " Eiichi Tsukata
2018-11-21 9:23 ` Christoph Hellwig
2018-11-22 5:42 ` Eiichi Tsukata [this message]
2018-11-21 2:44 ` [PATCH v1 4/4] overlayfs: " Eiichi Tsukata
2018-11-21 4:54 ` [PATCH v1 0/4] fs: " Al Viro
2018-11-22 5:40 ` Eiichi Tsukata
2018-11-22 7:06 ` Al Viro
2018-11-26 2:54 ` Eiichi Tsukata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANhTXPTk0BB7DTSx1uMMRGiBJD+x3qkde_Q6AmqiiY_t3dYTGg@mail.gmail.com \
--to=devel@etsukata.com \
--cc=adilger.kernel@dilger.ca \
--cc=agruenba@redhat.com \
--cc=andi@firstfloor.org \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=rpeterso@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).