From: Amir Goldstein <amir73il@gmail.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: fstests <fstests@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
Jeff Moyer <jmoyer@redhat.com>, Ext4 <linux-ext4@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] xfs/XXX: Add xfs/XXX
Date: Mon, 13 Apr 2020 19:11:46 +0300 [thread overview]
Message-ID: <CAOQ4uxg4Cr-vqA35TbhD5q7Jd1OgLUiL48nO_XNhkpMsCDW_UQ@mail.gmail.com> (raw)
In-Reply-To: <20200413155325.GA1560218@iweiny-DESK2.sc.intel.com>
> >
> > But the kernel patch suggests that there is an intention to make
> > this behavior also applicable to ext4??
> > If that is the case I would recommend making this a generic tests
> > which requires filesystem support for -o dax=XXX
>
> I have a patch set for ext4 which is not quite passing this. I'm not sure what
> is going on yet.
>
> Once that is working I was going to move this to generic. (The documentation
> in the kernel patch set also reflects ext4 being different from xfs for the
> time being.)
IMO, if ext4 maintainer is on board with the plan to make this behavior of
ext4 then it is best to add this test as generic from the start.
Any other filesystems that may tag along later?
>
> This is mainly because I'm not sure if ext4 will make 5.8 or not. Would you
> prefer making this generic now? I assume there is some way to mark generic
> tests for a subset of FS's? I have not figured that out yet.
>
There is a way, _supported_fs, see the tests/shared/*,
but the idea it to get rid of those in favor of feature tests such as
_require_scratch_dax
I believe it should be trivial to implement
_require_scratch_dax_never
Thanks,
Amir.
next prev parent reply other threads:[~2020-04-13 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 5:44 [PATCH] xfs/XXX: Add xfs/XXX ira.weiny
2020-04-13 7:54 ` Amir Goldstein
2020-04-13 15:53 ` Ira Weiny
2020-04-13 16:11 ` Amir Goldstein [this message]
2020-04-13 16:22 ` Darrick J. Wong
2020-04-13 16:30 ` Darrick J. Wong
2020-06-02 8:51 ` Xiao Yang
2020-06-02 18:14 ` Darrick J. Wong
2020-06-03 1:56 ` Xiao Yang
2020-06-03 3:49 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-04-07 18:30 ira.weiny
2020-02-27 5:38 ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxg4Cr-vqA35TbhD5q7Jd1OgLUiL48nO_XNhkpMsCDW_UQ@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).