From: Amir Goldstein <amir73il@gmail.com>
To: Waiman Long <longman@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Oleg Nesterov <oleg@redhat.com>, Jan Kara <jack@suse.cz>
Subject: Re: [RFC PATCH v2 2/2] locking/percpu-rwsem: Mark rwsem as non-spinnable in percpu_rwsem_release()
Date: Tue, 15 May 2018 10:04:20 +0300 [thread overview]
Message-ID: <CAOQ4uxgDFb1jgKBx9p=DVXqBpx_Jiw_zDggf5PPN+=qhv-xTsw@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxiL+x0Q8jgUZFOmrM5yndE0sDRRTSci2B-y5Y-r+QMCxA@mail.gmail.com>
On Tue, May 15, 2018 at 8:42 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Mon, May 14, 2018 at 10:31 PM, Waiman Long <longman@redhat.com> wrote:
>> The percpu_rwsem_release() is called when the ownership of the embedded
>> rwsem is to be transferred to another task. The new owner, however, may
>> take a while to get the ownership of the lock via percpu_rwsem_acquire().
>> During that period, the rwsem is now marked as writer-owned with no
>> optimistic spinning.
>>
>
> Waiman,
>
> Thanks for the fix. I will test it soon.
>
> For this commit message I suggest that you add parts of the reproducer
> found here:
> https://marc.info/?l=linux-fsdevel&m=152622016219975&w=2
>
fsfreeze is happy with these changes.
You may add:
Tested-by: Amir Goldstein <amir73il@gmail.com>
Thanks,
Amir.
next prev parent reply other threads:[~2018-05-15 7:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 19:31 [RFC PATCH v2 0/2] locking/rwsem: Fix DEBUG_RWSEM warning from thaw_sup Waiman Long
2018-05-14 19:31 ` [RFC PATCH v2 1/2] locking/rwsem: Add a new RWSEM_WRITER_OWNED_NOSPIN flag Waiman Long
2018-05-15 6:59 ` Amir Goldstein
2018-05-15 8:25 ` Peter Zijlstra
2018-05-14 19:31 ` [RFC PATCH v2 2/2] locking/percpu-rwsem: Mark rwsem as non-spinnable in percpu_rwsem_release() Waiman Long
2018-05-15 5:42 ` Amir Goldstein
2018-05-15 7:04 ` Amir Goldstein [this message]
2018-05-15 13:45 ` Waiman Long
2018-05-15 8:35 ` Peter Zijlstra
2018-05-15 9:00 ` Jan Kara
2018-05-15 11:33 ` Oleg Nesterov
2018-05-15 8:51 ` Peter Zijlstra
2018-05-15 11:06 ` Oleg Nesterov
2018-05-15 11:51 ` Peter Zijlstra
2018-05-15 12:45 ` Oleg Nesterov
2018-05-15 12:58 ` Peter Zijlstra
2018-05-15 13:57 ` Waiman Long
2018-05-15 14:00 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxgDFb1jgKBx9p=DVXqBpx_Jiw_zDggf5PPN+=qhv-xTsw@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=dave@stgolabs.net \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).