From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-yw1-f65.google.com ([209.85.161.65]:37888 "EHLO
        mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727030AbeJDRRm (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Thu, 4 Oct 2018 13:17:42 -0400
Received: by mail-yw1-f65.google.com with SMTP id d126-v6so3542100ywa.5
        for <linux-fsdevel@vger.kernel.org>; Thu, 04 Oct 2018 03:25:06 -0700 (PDT)
MIME-Version: 1.0
References: <20181003212539.2384-1-amir73il@gmail.com> <20181003212539.2384-7-amir73il@gmail.com>
 <20181004084141.GA11529@quack2.suse.cz>
In-Reply-To: <20181004084141.GA11529@quack2.suse.cz>
From: Amir Goldstein <amir73il@gmail.com>
Date: Thu, 4 Oct 2018 13:24:54 +0300
Message-ID: <CAOQ4uxgUJ9vJ75tqXozcDrfnjQw1s11rfk_UAd=guP3WUTjrEQ@mail.gmail.com>
Subject: Re: [PATCH v3 6/8] fanotify: add BUILD_BUG_ON() to count the bits of
 fanotify constants
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Oct 4, 2018 at 11:41 AM Jan Kara <jack@suse.cz> wrote:
>
> On Thu 04-10-18 00:25:37, Amir Goldstein wrote:
> > Also define the FANOTIFY_EVENT_FLAGS consisting of the extra flags
> > FAN_ONDIR and FAN_ON_CHILD.
> >
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ...
> >  /* Events that may be reported to user */
> >  #define FANOTIFY_OUTGOING_EVENTS     (FANOTIFY_EVENTS | \
> >                                        FANOTIFY_PERM_EVENTS | \
> >                                        FAN_Q_OVERFLOW)
> >
> > +#define ALL_FANOTIFY_EVENT_BITS              (FANOTIFY_EVENTS | \
> > +                                      FANOTIFY_PERM_EVENTS | \
> > +                                      FANOTIFY_EVENT_FLAGS | \
> > +                                      FANOTIFY_OUTGOING_EVENTS)
> > +
>
> No point in repeating FANOTIFY_EVENTS | FANOTIFY_PERM_EVENTS here when
> they are already included on FANOTIFY_OUTGOING_EVENTS, right? I can fix
> that up myself, just wanted to point it out.

It's fine to me.

Thanks,
Amir.