From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5614C433DF for ; Fri, 17 Jul 2020 03:49:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B171206F4 for ; Fri, 17 Jul 2020 03:49:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bfS1Bv0i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbgGQDtQ (ORCPT ); Thu, 16 Jul 2020 23:49:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbgGQDtP (ORCPT ); Thu, 16 Jul 2020 23:49:15 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8964FC061755 for ; Thu, 16 Jul 2020 20:49:15 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id q74so9067840iod.1 for ; Thu, 16 Jul 2020 20:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lG/4I+vgD25j0CnGJWaK0RYlCihUUn1WHkAFwdnwNUQ=; b=bfS1Bv0iE/l+Qnqd33feKrBCAt/KHn8xD9COCUrS1Fx0hdS5mXT/bWMfizAkDr33vg Vn+sGM+JoxfQeqZKtKfxfAxg3aYGNzOnvZcGPohCseAnCRMKjYF7B3xNOO4D3G6IOF+r /69I7Fu/s8+tVHptnh1mITsU/GMxYElQihluXDTDanm6CTQhCdFSueIkVOcKKQiT3GE+ Jcwx0nXtVeKzB83sI2z2e2EKlAyK7oRbCUMAcARoDCaI4enx5CMezc4FbHCv1IrW/0cs CPf/Ba9I2WojrkwPMCwbKcagLmB/YDcVbVJcw2qc5KhFV3YbV4H9bKsBv6H7HI7oX4Oo L/Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lG/4I+vgD25j0CnGJWaK0RYlCihUUn1WHkAFwdnwNUQ=; b=RiQst+skeM7ItMiHEKs/mutDuTI/Np3BMeaGnnIb+FrROZT1JCshEk0eY6Wg7tRISy +0mhFjeEdqQuVAm+OznfFSv5KEZeNvV/8w6knFjxUH/gkIX2CXu4uW3l5Q1FBdW5MldI FnDcgoI2f45SaAOsxv6z8k+kHoMyvJuv6l5zzwBLChLZxk38xP8G2J72Lr+xkUkewHmn OC2Y+kh0sfyu+f8OXzs4f0QAonoQnNwXrvUcrf8Gl+mDjV03hmrTftU4q6468YQgjxp4 PUNzjwMo1UXH9x5lZR4OXE45o1LMaoL/JwLfko02knZvZzhFM0u+WenontenibvwAFFp 6NxA== X-Gm-Message-State: AOAM530klqPwT0qOs4PqDJRemwdaOCfW/fhE78cASC1HZCHUdvLxoI52 tfUWgE85LYArb2WSdB42e7TkWThRrwJqR91QWEC6WbsR X-Google-Smtp-Source: ABdhPJwTsc4vD3ZRGONrOCCsWEozN0i6+ImeAzyFqX4miE6Qy47LjBsPuMqerhXGrxmBGlbb0zZHPplRdeJJDcU+fzQ= X-Received: by 2002:a6b:b483:: with SMTP id d125mr7670002iof.186.1594957754777; Thu, 16 Jul 2020 20:49:14 -0700 (PDT) MIME-Version: 1.0 References: <20200716084230.30611-1-amir73il@gmail.com> <20200716084230.30611-16-amir73il@gmail.com> <20200716170133.GJ5022@quack2.suse.cz> <20200716175709.GM5022@quack2.suse.cz> <20200716223441.GA5085@quack2.suse.cz> In-Reply-To: <20200716223441.GA5085@quack2.suse.cz> From: Amir Goldstein Date: Fri, 17 Jul 2020 06:49:03 +0300 Message-ID: Subject: Re: [PATCH v5 15/22] fsnotify: send event with parent/name info to sb/mount/non-dir marks To: Jan Kara Cc: linux-fsdevel Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org > OK, nice trick but for this series, I'd like to keep the original ignore > mask behavior (bug to bug compatibility) or possibly let parent's ignore > mask be applied only for events being sent to the parent due to its > FS_EVENT_ON_CHILD. That should be easy if we set the FS_EVENT_ON_CHILD flag only for the case of a watching parent. And I believe that would make the flag meaningful again and not redundant as you now see it. Please note that the series is already not "bug compatible", because the patch " send event to parent and child with single callback" already fixes the combination parent watch + child ignore, which did not work before and this is declared in commit message. > Can you please fix that up? Will do. I will also take care of LTP test coverage for the ignore mask cases that have been fixed and for dnotify/inotify parent+child watching case. > I won't get to it before I > leave for vacation but once I return, I'd like to just pick the fixed up > commit and push everything to linux-next... Thanks! > Thanks a lot for everything! Amir.