From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8EEC433E9 for ; Thu, 18 Feb 2021 09:59:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BD3764DDA for ; Thu, 18 Feb 2021 09:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230170AbhBRJzg (ORCPT ); Thu, 18 Feb 2021 04:55:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231450AbhBRJMu (ORCPT ); Thu, 18 Feb 2021 04:12:50 -0500 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E849C061756; Thu, 18 Feb 2021 01:10:12 -0800 (PST) Received: by mail-il1-x12f.google.com with SMTP id a16so852681ilq.5; Thu, 18 Feb 2021 01:10:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OgQOiOPnq0DRvI2eZdQvsHnaIaMA+0qyu71WaKASe+E=; b=KIj9uV247HXRj8/OdXi7y7ObktVMiQkfY1zBawc3yoqptXXOeQTlt477Lr0LhrSGE9 8E18Bxidf9al2BaaL4xQC/16sB1fQQ8/NXtUzgFeb2Tl+lMz/7TeP3pg/dihjZBohG7+ Se3QMaNt+hpWGzO7FbyL236gNrhjqG1KqA1QlNO2w/DwML7TfhYsXFaNCZB4laQDaY+F oZkmK4iDfnSJRr1w54d303Bkhc5/PFzSLgJ4odjLMS35jswywGq2QGEUU14unumiNnAN qpHtfXb5gITTwAbd5vZpb18FanWx4e2pmi6XDDLIZ6epHqg+bRzfy3Pt7kKhL+hAezW9 +e+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OgQOiOPnq0DRvI2eZdQvsHnaIaMA+0qyu71WaKASe+E=; b=kSJOO/Y2azAc3u998nFl7nQ5qNLFNurdH8g+1BiNILdwFp3z/Cbg78Ec3DCYtGUTkW G6TzrJ0qfnjiMtaLJB1p0nZTfLWl5xll32yNzUn9mekD6hDBSvR4+N6ZtNozRa5BeH+D w1SuBK6ayuobWjB6Z0AK5RkI2a5d+yAAx5Vv7QlOvQUZfs03XWVp2Zud57dUClRjg31g PjowJCqgQp9j2ZW+3OKKMQ3KrS5Xrclw6lIdYTSdGpYc/0Fhnm9+tLiE6TXD5jIjyJ7L M0RAANv/Hzs9Uim4X99ye5dx1RKvxfvr0kplb7o0Csom3MGhMJ5N2XaNUQM+2URgCZOa JOtA== X-Gm-Message-State: AOAM530FXwNwJvZiX1Idh5R0/zAXMxrgje0AjryZmgQmZWm9alLI+PHZ 5vQd2MnwpuMmkt2hwpITPklgq8+0qjAuO5FYR6o= X-Google-Smtp-Source: ABdhPJwxXq4k2yVJ6n1V7pcmcKjBIF0kyD/ZKAbc2Dz8lUF9r8GD81APTW8Ak1u3Tadv0KMLHxr+7GYAW078rcvAOLg= X-Received: by 2002:a92:8b89:: with SMTP id i131mr2975061ild.9.1613639411616; Thu, 18 Feb 2021 01:10:11 -0800 (PST) MIME-Version: 1.0 References: <20210215154317.8590-1-lhenriques@suse.de> <20210218074207.GA329605@infradead.org> In-Reply-To: <20210218074207.GA329605@infradead.org> From: Amir Goldstein Date: Thu, 18 Feb 2021 11:10:00 +0200 Message-ID: Subject: Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices To: Christoph Hellwig Cc: Luis Henriques , Jeff Layton , Steve French , Miklos Szeredi , Trond Myklebust , Anna Schumaker , Alexander Viro , "Darrick J. Wong" , Dave Chinner , Greg KH , Nicolas Boichat , Ian Lance Taylor , Luis Lozano , ceph-devel , linux-kernel , CIFS , samba-technical , linux-fsdevel , Linux NFS Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Feb 18, 2021 at 9:42 AM Christoph Hellwig wrote: > > Looks good: > > Reviewed-by: Christoph Hellwig > > This whole idea of cross-device copie has always been a horrible idea, > and I've been arguing against it since the patches were posted. Ok. I'm good with this v2 as well, but need to add the fallback to do_splice_direct() in nfsd_copy_file_range(), because this patch breaks it. And the commit message of v3 is better in describing the reported issue. Thanks, Amir.