linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Nixiaoming <nixiaoming@huawei.com>
Subject: Re: [PATCH v3 7/8] fanotify: support reporting thread id instead of process id
Date: Thu, 4 Oct 2018 13:27:54 +0300	[thread overview]
Message-ID: <CAOQ4uxhysePWSxTat4Y96B+r6gL4XGV=tbBQ=7ci=uLhekfWPQ@mail.gmail.com> (raw)
In-Reply-To: <20181004084608.GB11529@quack2.suse.cz>

On Thu, Oct 4, 2018 at 11:46 AM Jan Kara <jack@suse.cz> wrote:
>
> On Thu 04-10-18 00:25:38, Amir Goldstein wrote:
> > In order to identify which thread triggered the event in a
> > multi-threaded program, add the FAN_EVENT_INFO_TID flag in fanotify_init
> > to opt-in for reporting the event creator's thread id information.
> >
> > Signed-off-by: nixiaoming <nixiaoming@huawei.com>
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ...
> > diff --git a/include/linux/fanotify.h b/include/linux/fanotify.h
> > index afddd7e0d5a1..05b696b4856b 100644
> > --- a/include/linux/fanotify.h
> > +++ b/include/linux/fanotify.h
> > @@ -18,7 +18,10 @@
> >  #define FANOTIFY_CLASS_BITS  (FAN_CLASS_NOTIF | FAN_CLASS_CONTENT | \
> >                                FAN_CLASS_PRE_CONTENT)
> >
> > +#define FANOTIFY_EVENT_INFO_FLAGS    (FAN_EVENT_INFO_TID)
> > +
> >  #define FANOTIFY_INIT_FLAGS  (FANOTIFY_CLASS_BITS | \
> > +                              FANOTIFY_EVENT_INFO_FLAGS | \
> >                                FAN_CLOEXEC | FAN_NONBLOCK | \
> >                                FAN_UNLIMITED_QUEUE | FAN_UNLIMITED_MARKS)
>
> Is there reason to define FANOTIFY_EVENT_INFO_FLAGS? But I guess you
> prepare with this for further changes you want to do? Just that at this
> point it looks a bit silly and I cannot really think of a reason why we'd
> like to distinguish flags in FANOTIFY_EVENT_INFO_FLAGS from other flags in
> FANOTIFY_INIT_FLAGS...
>

No functional reason. Feel free to drop FANOTIFY_EVENT_INFO_FLAGS.

Thanks,
Amir.

  reply	other threads:[~2018-10-04 17:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 21:25 [PATCH v3 0/8] New fanotify event info API Amir Goldstein
2018-10-03 21:25 ` [PATCH v3 1/8] fanotify: fix collision of internal and uapi mark flags Amir Goldstein
2018-10-03 21:25 ` [PATCH v3 2/8] fsnotify: generalize handling of extra event flags Amir Goldstein
2018-10-03 21:25 ` [PATCH v3 3/8] fanotify: simplify handling of FAN_ONDIR Amir Goldstein
2018-10-03 21:25 ` [PATCH v3 4/8] fanotify: deprecate uapi FAN_ALL_* constants Amir Goldstein
2018-10-03 21:25 ` [PATCH v3 5/8] fsnotify: convert runtime BUG_ON() to BUILD_BUG_ON() Amir Goldstein
2018-10-03 21:25 ` [PATCH v3 6/8] fanotify: add BUILD_BUG_ON() to count the bits of fanotify constants Amir Goldstein
2018-10-04  8:41   ` Jan Kara
2018-10-04 10:24     ` Amir Goldstein
2018-10-03 21:25 ` [PATCH v3 7/8] fanotify: support reporting thread id instead of process id Amir Goldstein
2018-10-04  8:46   ` Jan Kara
2018-10-04 10:27     ` Amir Goldstein [this message]
2018-10-11 10:16   ` Jan Kara
2018-10-12  2:43     ` Nixiaoming
2018-10-16 12:06       ` Jan Kara
2018-10-03 21:25 ` [PATCH v3 8/8] fsnotify: optimize away srcu_read_lock() for events on directories Amir Goldstein
2018-10-04  9:09   ` Jan Kara
2018-10-04 10:30     ` Amir Goldstein
2018-10-04 11:26       ` Jan Kara
2018-10-04 22:05         ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxhysePWSxTat4Y96B+r6gL4XGV=tbBQ=7ci=uLhekfWPQ@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=nixiaoming@huawei.com \
    --subject='Re: [PATCH v3 7/8] fanotify: support reporting thread id instead of process id' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).