From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69FC2C433ED for ; Fri, 9 Apr 2021 16:06:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36D246115B for ; Fri, 9 Apr 2021 16:06:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232990AbhDIQHI (ORCPT ); Fri, 9 Apr 2021 12:07:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231402AbhDIQHH (ORCPT ); Fri, 9 Apr 2021 12:07:07 -0400 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D58AEC061760 for ; Fri, 9 Apr 2021 09:06:54 -0700 (PDT) Received: by mail-il1-x12f.google.com with SMTP id n4so5112741ili.8 for ; Fri, 09 Apr 2021 09:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lCbjbR89bYo1wK4UCkJv2P1iHuZdY6ZoBkGIARn0nT4=; b=LIgvLC1aTCkDTgS72fDeO1jVMHK3SL1uMjpX7H//4kUe0VLwwvPuPYLuFyQWmeiy3E U6pHA6VMMyzfn1EyrzBXP/vDSzJ89MOpAtx6XDj9is2uynprzB8YzxGMzlE0yNLlFIbK iVxu9csPq/Sepx4oHpB21Cq1a0JZY7U/dL4zl2Xh1sSQR+ruwoH7Y8CDSOyeysLk68ID UPzurIJ71CII5zYnujBijDEGCanCDXP0L+1yJcVWL0Z++V8U/H+trCA9JbM8+5/mmxnf R8FhHfpNJ7zs8Cmz2b7DmZefyjJXcCd1/tC4/ATCIQRRWPiEg8D8nvBW0fDQKNIMGCfG kdfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lCbjbR89bYo1wK4UCkJv2P1iHuZdY6ZoBkGIARn0nT4=; b=EWbpVmvuAOEcv0XKWIA3xV9CqO0JhZRn0wYk2DxN+2ms6ak9PMbnkCB5l+QjBmgU01 D06XOwsISdpW8dp66zIVNzkgjMC/jdbrORJAvR5TF1VUDfOI4sdIeGSpfKtP288MT6Sh f9wRjTgUzgOFxrwRKkowMkGGcVAiDQSFSiRXItzz/yO4RU2w8A+QUBd41PfW30/hkDSo dyfiszwV/g1mmmvflFQ+RygL81zoqaZYtzqjevNUXGrp+6YUgef1tfbn4B7IWTx4bHep umgdLSDq/rOehDCgNeZOZ2k9HaR7zoeZ7KfzXhOXznmlHuaY6sygTzbAxMV2KD84NaXV rm8A== X-Gm-Message-State: AOAM533m9rCevA2XAll8Wu1DspL+7F1ieqohhudn6OCcPXfmFboO0lf9 fQVkvw3Z2OGFl5Af2+9QEkJHW6SsO3iAs1jLmtY= X-Google-Smtp-Source: ABdhPJzz8acFv/BKMOgIArCzldfSGTDjIbI08qcOhmRB6/2vD8zeAbrbg/ImXhGm2az9bdRZF5GF6Za7E8iqcPaWvTY= X-Received: by 2002:a92:d44c:: with SMTP id r12mr12210110ilm.275.1617984414295; Fri, 09 Apr 2021 09:06:54 -0700 (PDT) MIME-Version: 1.0 References: <20210331125412.GI30749@quack2.suse.cz> <20210401102947.GA29690@quack2.suse.cz> <20210408125258.GB3271@quack2.suse.cz> <20210409100811.GA20833@quack2.suse.cz> In-Reply-To: From: Amir Goldstein Date: Fri, 9 Apr 2021 19:06:43 +0300 Message-ID: Subject: Re: fsnotify path hooks To: Al Viro Cc: Jan Kara , Christian Brauner , linux-fsdevel , Miklos Szeredi , "J. Bruce Fields" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Apr 9, 2021 at 5:30 PM Al Viro wrote: > > On Fri, Apr 09, 2021 at 04:22:58PM +0300, Amir Goldstein wrote: > > > But we are actually going in cycles around the solution that we all want, > > but fear of rejection. It's time to try and solicit direct feedback from Al. > > > > Al, > > > > would you be ok with passing mnt arg to vfs_create() and friends, > > so that we can pass that to fsnotify_create() (and friends) in order to > > be able to report FAN_CREATE events to FAN_MARK_MOUNT listeners? > > I would very much prefer to avoid going that way. OK, so I will go with the more "expressive" implementation that Jan suggested. Callers that do NOT care about mount mark semantics will use the wrapper: vfs_create_notify(mnt, ...) { vfs_create(... fsnotify_create(NULL,... } The two callers that do care about mount mark semantics (syscalls and nfsd) will open code: vfs_create(... fsnotify_create(mnt,... Hope that way works better for you. Thanks, Amir.