linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] vfs: explicitly include fileattr.h dependency
@ 2021-06-22 19:43 Keith Busch
  2021-06-22 19:55 ` Matthew Wilcox
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Keith Busch @ 2021-06-22 19:43 UTC (permalink / raw)
  To: linux-fsdevel; +Cc: Keith Busch, Miklos Szeredi, Matthew Wilcox, Jens Axboe :

linux/fileattr.h has an implicit requirement that linux/fs.h be included
first. Make that dependency explicit.

Cc: Miklos Szeredi <mszeredi@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Jens Axboe: <axboe@kernel.dk>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 include/linux/fileattr.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/fileattr.h b/include/linux/fileattr.h
index 9e37e063ac69..34e153172a85 100644
--- a/include/linux/fileattr.h
+++ b/include/linux/fileattr.h
@@ -3,6 +3,8 @@
 #ifndef _LINUX_FILEATTR_H
 #define _LINUX_FILEATTR_H
 
+#include <linux/fs.h>
+
 /* Flags shared betwen flags/xflags */
 #define FS_COMMON_FL \
 	(FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \
-- 
2.25.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] vfs: explicitly include fileattr.h dependency
  2021-06-22 19:43 [PATCH] vfs: explicitly include fileattr.h dependency Keith Busch
@ 2021-06-22 19:55 ` Matthew Wilcox
  2021-06-22 21:44 ` Jens Axboe
  2021-06-23  5:16 ` Amir Goldstein
  2 siblings, 0 replies; 4+ messages in thread
From: Matthew Wilcox @ 2021-06-22 19:55 UTC (permalink / raw)
  To: Keith Busch; +Cc: linux-fsdevel, Miklos Szeredi, Jens Axboe :

On Tue, Jun 22, 2021 at 12:43:00PM -0700, Keith Busch wrote:
> linux/fileattr.h has an implicit requirement that linux/fs.h be included
> first. Make that dependency explicit.
> 
> Cc: Miklos Szeredi <mszeredi@redhat.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Jens Axboe: <axboe@kernel.dk>
> Signed-off-by: Keith Busch <kbusch@kernel.org>

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] vfs: explicitly include fileattr.h dependency
  2021-06-22 19:43 [PATCH] vfs: explicitly include fileattr.h dependency Keith Busch
  2021-06-22 19:55 ` Matthew Wilcox
@ 2021-06-22 21:44 ` Jens Axboe
  2021-06-23  5:16 ` Amir Goldstein
  2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2021-06-22 21:44 UTC (permalink / raw)
  To: Keith Busch, linux-fsdevel; +Cc: Miklos Szeredi, Matthew Wilcox

On 6/22/21 1:43 PM, Keith Busch wrote:
> linux/fileattr.h has an implicit requirement that linux/fs.h be included
> first. Make that dependency explicit.

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] vfs: explicitly include fileattr.h dependency
  2021-06-22 19:43 [PATCH] vfs: explicitly include fileattr.h dependency Keith Busch
  2021-06-22 19:55 ` Matthew Wilcox
  2021-06-22 21:44 ` Jens Axboe
@ 2021-06-23  5:16 ` Amir Goldstein
  2 siblings, 0 replies; 4+ messages in thread
From: Amir Goldstein @ 2021-06-23  5:16 UTC (permalink / raw)
  To: Keith Busch; +Cc: linux-fsdevel, Miklos Szeredi, Matthew Wilcox, Jens Axboe :

On Tue, Jun 22, 2021 at 10:47 PM Keith Busch <kbusch@kernel.org> wrote:
>
> linux/fileattr.h has an implicit requirement that linux/fs.h be included
> first. Make that dependency explicit.
>
> Cc: Miklos Szeredi <mszeredi@redhat.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Jens Axboe: <axboe@kernel.dk>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
>  include/linux/fileattr.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/fileattr.h b/include/linux/fileattr.h
> index 9e37e063ac69..34e153172a85 100644
> --- a/include/linux/fileattr.h
> +++ b/include/linux/fileattr.h
> @@ -3,6 +3,8 @@
>  #ifndef _LINUX_FILEATTR_H
>  #define _LINUX_FILEATTR_H
>
> +#include <linux/fs.h>
> +
>  /* Flags shared betwen flags/xflags */
>  #define FS_COMMON_FL \
>         (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \
> --

Thinking out loud:
Would it be better to split out the flag definitions to uapi/linux/fileattr.h
and include it from here and from uapi/linux/fs.h?

Will that cause UAPI pain??

Thanks,
Amir.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-23  5:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 19:43 [PATCH] vfs: explicitly include fileattr.h dependency Keith Busch
2021-06-22 19:55 ` Matthew Wilcox
2021-06-22 21:44 ` Jens Axboe
2021-06-23  5:16 ` Amir Goldstein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).