From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Boaz Harrosh <boaz@plexistor.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 0/3 v2] xfs: Fix races between readahead and hole punching
Date: Fri, 17 Jan 2020 12:50:58 +0200 [thread overview]
Message-ID: <CAOQ4uxiDqtpsH_Ot5N+Avq0h5MBXsXwgDdNbdRC0QDZ-e+zefg@mail.gmail.com> (raw)
In-Reply-To: <20190829131034.10563-1-jack@suse.cz>
On Thu, Aug 29, 2019 at 4:10 PM Jan Kara <jack@suse.cz> wrote:
>
> Hello,
>
> this is a patch series that addresses a possible race between readahead and
> hole punching Amir has discovered [1]. The first patch makes madvise(2) to
> handle readahead requests through fadvise infrastructure, the third patch
> then adds necessary locking to XFS to protect against the race. Note that
> other filesystems need similar protections but e.g. in case of ext4 it isn't
> so simple without seriously regressing mixed rw workload performance so
> I'm pushing just xfs fix at this moment which is simple.
>
Jan,
Could you give a quick status update about the state of this issue for
ext4 and other fs. I remember some solutions were discussed.
Perhaps this could be a good topic for a cross track session in LSF/MM?
Aren't the challenges posed by this race also relevant for RWF_UNCACHED?
Thanks,
Amir.
next prev parent reply other threads:[~2020-01-17 10:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 13:10 [PATCH 0/3 v2] xfs: Fix races between readahead and hole punching Jan Kara
2019-08-29 13:10 ` [PATCH 1/3] mm: Handle MADV_WILLNEED through vfs_fadvise() Jan Kara
2019-08-29 15:49 ` Darrick J. Wong
2019-08-29 13:10 ` [PATCH 2/3] fs: Export generic_fadvise() Jan Kara
2019-08-29 13:10 ` [PATCH 3/3] xfs: Fix stale data exposure when readahead races with hole punch Jan Kara
2019-08-29 15:52 ` Darrick J. Wong
2019-08-30 15:24 ` Jan Kara
2019-08-30 16:02 ` Darrick J. Wong
2019-09-18 12:31 ` Jan Kara
2019-09-18 16:07 ` Darrick J. Wong
2019-09-23 12:33 ` Boaz Harrosh
2019-09-24 15:23 ` Jan Kara
2019-09-24 15:45 ` Boaz Harrosh
2020-01-17 10:50 ` Amir Goldstein [this message]
2020-01-19 8:35 ` [PATCH 0/3 v2] xfs: Fix races between readahead and hole punching Amir Goldstein
2020-01-20 11:47 ` Jan Kara
2020-01-20 12:03 ` Jan Kara
2020-01-20 13:54 ` Amir Goldstein
2020-01-20 16:58 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxiDqtpsH_Ot5N+Avq0h5MBXsXwgDdNbdRC0QDZ-e+zefg@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=boaz@plexistor.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).