From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-f47.google.com ([209.85.161.47]:35369 "EHLO mail-yw1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729510AbeJAUrO (ORCPT ); Mon, 1 Oct 2018 16:47:14 -0400 Received: by mail-yw1-f47.google.com with SMTP id y76-v6so5526705ywd.2 for ; Mon, 01 Oct 2018 07:09:15 -0700 (PDT) MIME-Version: 1.0 References: <20180927162412.GA12883@quack2.suse.cz> In-Reply-To: From: Amir Goldstein Date: Mon, 1 Oct 2018 17:09:04 +0300 Message-ID: Subject: Re: Deadlock in fsnotify for To: Nigel_Banks@waters.com Cc: Jan Kara , linux-fsdevel , Mark Salyzyn Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Oct 1, 2018 at 1:29 PM Nigel Banks wrote: > > Thank you Amir, > > I will try the patch you've recommend. It some times takes several days for this issue to arise, so you may not hear back from me for a week or so. On a side note if I were to use AUFS instead of Overlay2 would that potentially avoid this issue? > I don't know the answer to that question, but there is an easy way to find out. The fix patch has a simple reproducer in commit message. Run the same reproducer with AUFS instead of overlayfs and tell me. I can only say that AFAIK all past versions of overlayfs has had this problem with inotify. I can also say that if you have a hardlink in lower layer and you are not using the new overlayfs index feature (docker is not using this feature) then said inotify issue will still happen on that lower hardlink. Thanks, Amir.