From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-yw1-f67.google.com ([209.85.161.67]:41102 "EHLO
        mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728547AbeK2CDU (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 28 Nov 2018 21:03:20 -0500
Received: by mail-yw1-f67.google.com with SMTP id f65so10812374ywc.8
        for <linux-fsdevel@vger.kernel.org>; Wed, 28 Nov 2018 07:01:23 -0800 (PST)
MIME-Version: 1.0
References: <20181125134352.21499-1-amir73il@gmail.com> <20181125134352.21499-2-amir73il@gmail.com>
 <20181128125903.GE15604@quack2.suse.cz> <CAOQ4uxj1QEyQLWjYEjauAR5vND0xwHYQ=s_ci2S2EyezQ6AsCQ@mail.gmail.com>
 <20181128144316.GH15604@quack2.suse.cz>
In-Reply-To: <20181128144316.GH15604@quack2.suse.cz>
From: Amir Goldstein <amir73il@gmail.com>
Date: Wed, 28 Nov 2018 17:01:11 +0200
Message-ID: <CAOQ4uxit29i+FTe7TQfQCMuF5wqEpx791qRWMBSVivqezyLZqg@mail.gmail.com>
Subject: Re: [PATCH v3 01/13] fsnotify: annotate directory entry modification events
To: Jan Kara <jack@suse.cz>
Cc: Matthew Bobrowski <mbobrowski@mbobrowski.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Nov 28, 2018 at 4:43 PM Jan Kara <jack@suse.cz> wrote:
>
> On Wed 28-11-18 16:39:31, Amir Goldstein wrote:
> > On Wed, Nov 28, 2018 at 2:59 PM Jan Kara <jack@suse.cz> wrote:
> > > > +/*
> > > > + * This is a list of all events that may get sent to a parent based on fs event
> > >
> > > ^^^ Line too long.
> >
> > Heh?? checkpatch did not complain. It's 79 chars.
>
> My bad, just the quoting in the reply pushed the line over 80 chars and I
> didn't realize that.
>
> > >
> > > > +#define ALL_FSNOTIFY_EVENTS (ALL_FSNOTIFY_DIRENT_EVENTS| \
> > >                                                         ^^^ space here
> > >
> >
> > My patch did not change indentation AFAIK.
> > The new definition added is with tab (ALL_FSNOTIFY_DIRENT_EVENTS)
> > but some of the existing definitions, even ones moved around are with space(s).
> > Do you want me to change that?
>
> This is not about indentation but space before '|' operator...
>
Ah. ok. fixed.

Thanks,
Amir.