From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-f196.google.com ([209.85.219.196]:37685 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726867AbeI1UwE (ORCPT ); Fri, 28 Sep 2018 16:52:04 -0400 Received: by mail-yb1-f196.google.com with SMTP id h1-v6so582151ybm.4 for ; Fri, 28 Sep 2018 07:28:02 -0700 (PDT) MIME-Version: 1.0 References: <20180927162412.GA12883@quack2.suse.cz> In-Reply-To: From: Amir Goldstein Date: Fri, 28 Sep 2018 17:27:50 +0300 Message-ID: Subject: Re: Deadlock in fsnotify for To: Nigel_Banks@waters.com Cc: Jan Kara , linux-fsdevel , Mark Salyzyn Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Sep 28, 2018 at 4:47 PM Nigel Banks wrote: > > Hello Again, > > I've attached the kern.log as you instructed, please let me know if there is any more information I can provide. > > > > Cheers, > > Nigel > > > > From: Jan Kara > To: Nigel Banks > Cc: jack@suse.cz, linux-fsdevel@vger.kernel.org, Amir Goldstein > Date: 09/27/2018 05:24 PM > Subject: Re: Deadlock in fsnotify for > ________________________________ > > > > Hello, > > [added to CC other relevant mails] > > On Thu 27-09-18 16:44:53, Nigel Banks wrote: > > Sorry to trouble you, but from looking through the git history of linux/fs/ > > notify you seem to be the best person to contact. > > > > I've encounter a hard to reproduce situation that happens on our CI > > servers, in which it becomes impossible to release any inotify file > > descriptors. We're currently running Ubuntu 18.04 (Kernel 4.15) using > > ext4 fs, and our code is running in docker containers (overlay2) if that > > makes a difference. > > Nigel, It actually could make a difference. commit 764baba80168 ("ovl: hash non-dir by lower inode for fsnotify"). never made it to stable trees - it got stuck in the process: https://www.spinics.net/lists/stable/msg250441.html Can you check if Mark's backport patch (in the link above) solves your problem? I have written an LTP test case to cover the fix - inotify08 and I can confirm that the test fails on Ubuntu 18.04, but the test does not result in a hang, it results in events not being delivered, so not sure it is related to the issue you are seeing. In any case, running inotofi over overlayfs without this fix is not a good idea. Mark, Could you please re-post the backport patch per Greg's request. Thanks, Amir.