From: Kenny Ho <y2kenny@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Kenny Ho <Kenny.Ho@amd.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>, bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
"open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL
Date: Tue, 3 Nov 2020 17:57:47 -0500 [thread overview]
Message-ID: <CAOWid-djQ_NRfCbOTnZQ-A8Pr7jMP7KuZEJDSsvzWkdw7qc=yA@mail.gmail.com> (raw)
In-Reply-To: <20201103210418.q7hddyl7rvdplike@ast-mbp.dhcp.thefacebook.com>
On Tue, Nov 3, 2020 at 4:04 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Tue, Nov 03, 2020 at 02:19:22PM -0500, Kenny Ho wrote:
> > On Tue, Nov 3, 2020 at 12:43 AM Alexei Starovoitov
> > <alexei.starovoitov@gmail.com> wrote:
> > > On Mon, Nov 2, 2020 at 9:39 PM Kenny Ho <y2kenny@gmail.com> wrote:
>
> Sounds like either bpf_lsm needs to be made aware of cgv2 (which would
> be a great thing to have regardless) or cgroup-bpf needs a drm/gpu specific hook.
> I think generic ioctl hook is too broad for this use case.
> I suspect drm/gpu internal state would be easier to access inside
> bpf program if the hook is next to gpu/drm. At ioctl level there is 'file'.
> It's probably too abstract for the things you want to do.
> Like how VRAM/shader/etc can be accessed through file?
> Probably possible through a bunch of lookups and dereferences, but
> if the hook is custom to GPU that info is likely readily available.
> Then such cgroup-bpf check would be suitable in execution paths where
> ioctl-based hook would be too slow.
Just to clarify, when you say drm specific hook, did you mean just a
unique attach_type or a unique prog_type+attach_type combination? (I
am still a bit fuzzy on when a new prog type is needed vs a new attach
type. I think prog type is associated with a unique type of context
that the bpf prog will get but I could be missing some nuances.)
When I was thinking of doing an ioctl wide hook, the file would be the
device file and the thinking was to have a helper function provided by
device drivers to further disambiguate. For our (AMD's) driver, we
have a bunch of ioctls for set/get/create/destroy
(https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c#L1763)
so the bpf prog can make the decision after the disambiguation. For
example, we have an ioctl called "kfd_ioctl_set_cu_mask." You can
think of cu_mask like cpumask but for the cores/compute-unit inside a
GPU. The ioctl hook will get the file, the bpf prog will call a
helper function from the amdgpu driver to return some data structure
specific to the driver and then the bpf prog can make a decision on
gating the ioctl or not. From what you are saying, sounds like this
kind of back and forth lookup and dereferencing should be avoided for
performance considerations?
Having a DRM specific hook is certainly an alternative. I just wasn't
sure which level of trade off on abstraction/generic is acceptable. I
am guessing a new BPF_PROG_TYPE_CGROUP_AMDGPU is probably too
specific? But sounds like BPF_PROG_TYPE_CGROUP_DRM may be ok?
Regards,
Kenny
next prev parent reply other threads:[~2020-11-03 22:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 15:23 [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL Kenny Ho
2020-11-02 19:23 ` Kenny Ho
2020-11-03 5:32 ` Alexei Starovoitov
2020-11-03 5:39 ` Kenny Ho
2020-11-03 5:42 ` Alexei Starovoitov
2020-11-03 19:19 ` Kenny Ho
2020-11-03 21:04 ` Alexei Starovoitov
2020-11-03 22:57 ` Kenny Ho [this message]
2020-11-03 23:28 ` Alexei Starovoitov
2021-02-01 14:49 ` Daniel Vetter
2021-02-01 16:51 ` Kenny Ho
2021-02-03 11:09 ` Daniel Vetter
2021-02-03 19:01 ` Kenny Ho
2021-02-05 13:49 ` Daniel Vetter
2021-05-07 2:06 ` Kenny Ho
2021-05-07 8:59 ` Daniel Vetter
2021-05-07 15:33 ` Kenny Ho
2021-05-07 16:13 ` Daniel Vetter
2021-05-07 16:19 ` Alex Deucher
2021-05-07 16:26 ` Daniel Vetter
2021-05-07 16:31 ` Alex Deucher
2021-05-07 16:50 ` Alex Deucher
2021-05-07 16:54 ` Daniel Vetter
2021-05-07 17:04 ` Kenny Ho
2021-05-07 19:33 ` Tejun Heo
2021-05-07 19:55 ` Alex Deucher
2021-05-07 20:59 ` Tejun Heo
2021-05-07 22:30 ` Alex Deucher
2021-05-07 23:45 ` Tejun Heo
2021-05-11 15:48 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOWid-djQ_NRfCbOTnZQ-A8Pr7jMP7KuZEJDSsvzWkdw7qc=yA@mail.gmail.com' \
--to=y2kenny@gmail.com \
--cc=Kenny.Ho@amd.com \
--cc=alexander.deucher@amd.com \
--cc=alexei.starovoitov@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).