linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Smas <andreas@lonelycoder.com>
To: axboe@kernel.dk, linux-fsdevel@vger.kernel.org
Subject: io_uring, IORING_OP_RECVMSG and ancillary data
Date: Sat, 25 Apr 2020 10:29:08 -0700	[thread overview]
Message-ID: <CAObFT-S27KXFGomqPZdXA8oJDe6QxmoT=T6CBgD9R9UHNmakUQ@mail.gmail.com> (raw)

Hi,

Tried to use io_uring with OP_RECVMSG with ancillary buffers (for my
particular use case I'm using SO_TIMESTAMP for incoming UDP packets).

These submissions fail with EINVAL due to the check in __sys_recvmsg_sock().

The following hack fixes the problem for me and I get valid timestamps
back. Not suggesting this is the real fix as I'm not sure what the
implications of this is.

Any insight into this would be much appreciated.

Thanks,
Andreas

diff --git a/net/socket.c b/net/socket.c
index 2dd739fba866..689f41f4156e 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -2637,10 +2637,6 @@ long __sys_recvmsg_sock(struct socket *sock,
struct msghdr *msg,
                        struct user_msghdr __user *umsg,
                        struct sockaddr __user *uaddr, unsigned int flags)
 {
-       /* disallow ancillary data requests from this path */
-       if (msg->msg_control || msg->msg_controllen)
-               return -EINVAL;
-
        return ____sys_recvmsg(sock, msg, umsg, uaddr, flags, 0);
 }

             reply	other threads:[~2020-04-25 17:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25 17:29 Andreas Smas [this message]
2020-04-25 20:23 ` io_uring, IORING_OP_RECVMSG and ancillary data Jens Axboe
2020-04-27 19:20   ` Jann Horn
2020-04-27 19:29     ` Jens Axboe
2020-04-27 19:53       ` Jens Axboe
2020-04-27 20:03         ` Jann Horn
2020-04-27 20:08           ` Jens Axboe
2020-04-27 20:10             ` Christoph Hellwig
2020-04-27 20:13               ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAObFT-S27KXFGomqPZdXA8oJDe6QxmoT=T6CBgD9R9UHNmakUQ@mail.gmail.com' \
    --to=andreas@lonelycoder.com \
    --cc=axboe@kernel.dk \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).