From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E039C4151A for ; Sun, 3 Feb 2019 14:44:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0FCB2084A for ; Sun, 3 Feb 2019 14:44:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=omnibond-com.20150623.gappssmtp.com header.i=@omnibond-com.20150623.gappssmtp.com header.b="dnPEgRPm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727863AbfBCOov (ORCPT ); Sun, 3 Feb 2019 09:44:51 -0500 Received: from mail-yw1-f67.google.com ([209.85.161.67]:39123 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727726AbfBCOov (ORCPT ); Sun, 3 Feb 2019 09:44:51 -0500 Received: by mail-yw1-f67.google.com with SMTP id k188so4740788ywa.6 for ; Sun, 03 Feb 2019 06:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omnibond-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kbxwqhoz9HKhZfqubBwdXLFT04SMOzjovrXL0WG1qcA=; b=dnPEgRPm8WlfRQnjfMVsrDv64iemmknBa+okcO2HufFN7dyade3pqCjP44/JhJ/USM xDZkiB+qRVEPIitdVuYt9ZNgfF+G3S86PDszzx/4Pg82mdJU14xxvay8J0CKwR5zwKTk /1VU0Y5zz4fahKsuY69KSl+1jDfVftsB/r+k0k5au7fHtDAoxEiwcwYJrjVAdSLmY6hh QGaFfQXtpuMrSTTwRywyWJUtHpyeSzKXOXdRT+9W+jNgM2kvD0vu4ABrROnv7uYZ8+nE Zldngj41H98dfDfshTFHOKFTPT4VN9YkrLczEsaFZBzHMUO316id0/XbdddxhvwbFnYf LluA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kbxwqhoz9HKhZfqubBwdXLFT04SMOzjovrXL0WG1qcA=; b=GXs91OFhVOgb06O/a//343bHiif0ZVfe6aNuwmWDF8aNgArUdS6ZoNn8XHP/BCvvHk FANHYpn5wZ2cO/adaO1gOkti0qOmDO14CQTTN+7zyPPFQURIc4B5jdYiqHgMV06Z3h8v yrRmwI6M6zIZSvzFdY0lwXDRhbxEWWHlyrk+/w4Q/1ysF1og8VKVTRGRp1A2FsO//+Br joBN85rT9yJ/omp/QoG++iPSaoMRP0+wkJPN1UMkyQQIdKUpgOsCR7hbGQ+OpAg7/0Qr 7hVieHfN1+Ny+KcA5g0jLQE7mo8lE0qG/WvF2ZhUx2phkj3aISuUTrsi0UiIJXuDb5fV 8dfw== X-Gm-Message-State: AJcUukeLRvqVNBY64PP22r/TIMQq0y038/K+cM85lq+ZQck4j8A08o+T +fgAjWAhKVPcjtJYf1lRIpCewczaNMx0XU8ePzkmVg== X-Google-Smtp-Source: ALg8bN7q/C4bs3I80cs4dlt/MgFd5CujNj2aZXKBYkmL21aPMG7aceYu4S1lnc3gbhhQwH4y2G21U9bWGsZNfUl1Xfs= X-Received: by 2002:a81:b243:: with SMTP id q64mr44190676ywh.351.1549205090153; Sun, 03 Feb 2019 06:44:50 -0800 (PST) MIME-Version: 1.0 References: <20190121152326.9954-1-hch@lst.de> <20190121152326.9954-2-hch@lst.de> In-Reply-To: <20190121152326.9954-2-hch@lst.de> From: Mike Marshall Date: Sun, 3 Feb 2019 09:44:38 -0500 Message-ID: Subject: Re: [PATCH 1/2] orangefs: don't reinitialize result_mask in ->getattr To: Christoph Hellwig Cc: Al Viro , David Howells , Martin Brandenburg , linux-fsdevel , linux-xfs@vger.kernel.org, devel@lists.orangefs.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org It looks good to both Martin and I, and runs fine through xfstests... you can add Signed-off-by: Mike Marshall -Mike "is there a finally-signed-off-by tag?" On Mon, Jan 21, 2019 at 10:23 AM Christoph Hellwig wrote: > > The caller already initializes it to the basic stats. Just > clear not supported default bits where needed. > > Signed-off-by: Christoph Hellwig > --- > fs/orangefs/inode.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c > index f038235c64bd..c3334eca18c7 100644 > --- a/fs/orangefs/inode.c > +++ b/fs/orangefs/inode.c > @@ -261,11 +261,8 @@ int orangefs_getattr(const struct path *path, struct kstat *stat, > generic_fillattr(inode, stat); > > /* override block size reported to stat */ > - if (request_mask & STATX_SIZE) > - stat->result_mask = STATX_BASIC_STATS; > - else > - stat->result_mask = STATX_BASIC_STATS & > - ~STATX_SIZE; > + if (!(request_mask & STATX_SIZE)) > + stat->result_mask &= ~STATX_SIZE; > > stat->attributes_mask = STATX_ATTR_IMMUTABLE | > STATX_ATTR_APPEND; > -- > 2.20.1 >